Merge pull request rough-stuff#222 from rough-stuff/fraction-gap

round the gap value for the algorithm
swaitw · Nov 20, 2023 · 56a2762 · 56a2762
2 parents 4293e89 + d0f5081
commit 56a2762
Show file tree

Hide file tree

Showing 4 changed files with 87 additions and 61 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "roughjs",
-  "version": "4.6.5",
+  "version": "4.6.6",
   "description": "Create graphics using HTML Canvas or SVG with a hand-drawn, sketchy, appearance.",
   "main": "bundled/rough.cjs.js",
   "module": "bundled/rough.esm.js",

diff --git a/src/fillers/scan-line-hachure.ts b/src/fillers/scan-line-hachure.ts
@@ -8,7 +8,7 @@ export function polygonHachureLines(polygonList: Point[][], o: ResolvedOptions):
   if (gap < 0) {
     gap = o.strokeWidth * 4;
   }
-  gap = Math.max(gap, 0.1);
+  gap = Math.round(Math.max(gap, 0.1));
   let skipOffset = 1;
   if (o.roughness >= 1) {
     if ((o.randomizer?.next() || Math.random()) > 0.7) {

diff --git a/visual-tests/svg/rectangle2.html b/visual-tests/svg/rectangle2.html
@@ -0,0 +1,26 @@
+<!doctype html>
+<html lang="en">
+
+<head>
+  <meta charset="utf-8">
+  <meta name="viewport" content="width=device-width, minimum-scale=1, initial-scale=1, user-scalable=yes">
+  <title>RoughJS Rectangle</title>
+</head>
+
+<body>
+  <svg width="800" height="800"></svg>
+
+  <script type="module">
+    import rough from '../../bin/rough.js';
+    const svg = document.querySelector('svg');
+    const rc = rough.svg(svg);
+
+    svg.appendChild(rc.rectangle(10, 10, 280, 280, {
+      fill: 'red',
+      hachureGap: 1.7
+    }));
+
+  </script>
+</body>
+
+</html>