Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigator related changes to allow further customization #904

Merged
merged 7 commits into from
Oct 21, 2024

Conversation

hqhhuang
Copy link
Contributor

@hqhhuang hqhhuang commented Oct 18, 2024

Issue: rdar://138215815

Summary

We've been landing changes on the navigator-index-store branch:
#889
#895
#896
#897

This PR merges them to main.

Dependencies

NA

Testing

Steps:

  1. Newly added tests should pass
  2. Ensure this PR does not introduce regressions.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

hqhhuang and others added 5 commits September 16, 2024 09:59
Creating an `IndexStore` for Quick Navigation (#889) rdar://134272215
Create a mixin for the index data getting logic (#895) rdar://136089361
`Navigator` gets data from `IndexStore` (#896)  rdar://134347681
…34362686

Adding slots to allow further navigator customization (#897) rdar://134362686
@hqhhuang
Copy link
Contributor Author

@swift-ci test

`includedArchiveIdentifier` moved to `IndexStore`
@hqhhuang
Copy link
Contributor Author

@swift-ci test

@eango eango self-requested a review October 21, 2024 23:03
@mportiz08 mportiz08 merged commit a0186a1 into main Oct 21, 2024
1 check passed
@mportiz08 mportiz08 deleted the navigator-index-store branch October 21, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants