[TypeChecker] Avoid dropping pre-check diagnostics in `typeCheckParam… #80280
+32
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
commented
Mar 25, 2025
hamishknight
approved these changes
Mar 25, 2025
|
We shouldn’t be using diagnostic transactions at all. The whole concept is fundamentally incompatible with the request evaluator. |
|
I don't think anybody disagrees with that :) |
|
@swift-ci please test |
|
We should fold this into the constraint solver itself, that would eliminate the need for diagnostic transactions in this particular case. |
…eterDefault`
`typeCheck{Expression, Target}` has a pre-check phase which would
replace some invalid AST nodes (i.e. name references that are not
available in the given declaration context) with `ErrorExpr`s and
emit a diagnostic. Such diagnostics were then dropped by `abort()`
call to a diagnostic transaction. This results in invalid code being
accepted by Sema and forwarded to SILGen.
Resolves: swiftlang#73986
Resolves: rdar://131732245
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eterDefault`
typeCheck{Expression, Target}has a pre-check phase which would replace some invalid AST nodes (i.e. name references that are not available in the given declaration context) withErrorExprs and emit a diagnostic. Such diagnostics were then dropped byabort()call to a diagnostic transaction. This results in invalid code being accepted by Sema and forwarded to SILGen.Resolves: #73986
Resolves: rdar://131732245