Sema: Extend _unsafeInheritExecutor_ hack to Clock.measure()
#80333
+46
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the bug in `swift::introduceUnsafeInheritExecutorReplacements()` that prevented the hack from working with `Clock.measure()`. It isn't sufficient to just check whether the nominal for the type base of a qualified lookup belongs to the Concurrency module because that type may reference multiple types. Instead, check all of the directly referenced types to match the behavior of qualified lookup. Resolves rdar://132581483.
|
@swift-ci please test |
tshortli
requested review from
ktoso,
hborla,
slavapestov and
xedin
as code owners
|
@DougGregor does this look reasonable to you? |
DougGregor
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug in
swift::introduceUnsafeInheritExecutorReplacements()that prevented the hack from working withClock.measure(). It isn't sufficient to just check whether the nominal for the type base of a qualified lookup belongs to the Concurrency module because that type may reference multiple types. Instead, check all of the directly referenced types to match the behavior of qualified lookup.Resolves rdar://132581483.