Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Concurrency] Fix new build script. #80408

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

al45tair
Copy link
Contributor

Looks like a new CMakelists.txt got added to the new build system while I was working on this.

Looks like a new CMakelists.txt got added to the new build system while
I was working on this.
@al45tair
Copy link
Contributor Author

@swift-ci Please smoke test

@al45tair
Copy link
Contributor Author

This was previously approved as part of #80195.

Copy link
Contributor

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any differences from #80195 with regard to the new build system anyway. Which new file was added? Do we still need the changes to the old build that was also in that PR?

@al45tair
Copy link
Contributor Author

#80195 wasn't merged, because the concurrency changes were reverted. When I un-reverted them, I missed the commit that updated the new build system.

@al45tair
Copy link
Contributor Author

The other change from that PR was in the un-revert PR (I just missed this one).

@al45tair al45tair enabled auto-merge March 31, 2025 16:51
@shahmishal shahmishal disabled auto-merge March 31, 2025 18:17
@shahmishal shahmishal merged commit 431138b into swiftlang:main Mar 31, 2025
0 of 3 checks passed
@al45tair
Copy link
Contributor Author

Failure isn't related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants