Frontend: Reinstate suppression of warnings during interface type-checking #80415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
approved these changes
Mar 31, 2025
tshortli
force-pushed
the
suppress-warnings-when-typechecking-module-interfaces
branch
from
994ac78 to
ec6acfd
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test Windows |
beccadax
requested changes
Apr 1, 2025
…cking. We're not ready to start emitting warnings when type-checking modules from interface. It is causing performance regressions and spurious diagnostics to be emitted. Reverts a small part of swiftlang#80360. Resolves rdar://148257136.
tshortli
force-pushed
the
suppress-warnings-when-typechecking-module-interfaces
branch
from
ec6acfd to
645628f
Compare
|
@swift-ci please smoke test |
tshortli
deleted the
suppress-warnings-when-typechecking-module-interfaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not ready to start emitting warnings when type-checking modules from interface. It is causing performance regressions and spurious diagnostics to be emitted.
Reverts a small part of #80360.
Resolves rdar://148257136.