-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project Panel #1382
Merged
Merged
Project Panel #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd0502a
to
191e52f
Compare
b803a60
to
0a8e846
Compare
Convert the dependencies panel in to the new project panel. This rolls the dependencies up in to its own top level item in the tree, and places it along side Targets, Tasks, Commands and Snippets. Tasks, Commands and Snippets can be run directly from the panel, and update their icon to show their running status. Clicking a test target will run all the tests in the target.
0a8e846
to
1e1da9e
Compare
matthewbastien
approved these changes
Feb 25, 2025
vscode.commands.registerCommand(Commands.RUN, () => runBuild(ctx)), | ||
vscode.commands.registerCommand(Commands.DEBUG, () => debugBuild(ctx)), | ||
vscode.commands.registerCommand(Commands.RUN, target => | ||
runBuild(ctx, ...unwrapTreeItem(target)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to mention that SourceKit-LSP will include the target name as a string for the swift.run
and swift.debug
commands starting in 6.2, but it looks like that case is already covered by unwrapTreeItem()
. Nice.
plemarquand
added a commit
that referenced
this pull request
Feb 28, 2025
This reverts commit 5753b6b.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the dependencies panel in to the new project panel. This rolls the dependencies up in to its own top level item in the tree, and places it along side Targets, Tasks, Commands and Snippets.
Tasks, Commands and Snippets can be run directly from the panel, and update their icon to show their running status.
Clicking a test target will run all the tests in the target.