add isInspectable property

Reviewed By: Hypuk Differential Revision: D6578736 fbshipit-source-id: a4229c3766125ff55cff50a49893b2385f9c8a6a
swissmanu · Dec 18, 2017 · 15cd98b · 15cd98b
1 parent 3852c42
commit 15cd98b
Show file tree

Hide file tree

Showing 7 changed files with 26 additions and 0 deletions.
diff --git a/React/Base/RCTBatchedBridge.mm b/React/Base/RCTBatchedBridge.mm
@@ -1094,4 +1094,10 @@ - (JSContext *)jsContext
   }
 }
 
+#pragma mark - Inspector
+
+- (BOOL)isInspectable {
+  return NO;
+}
+
 @end
diff --git a/React/Base/RCTBridge+Private.h b/React/Base/RCTBridge+Private.h
@@ -168,6 +168,12 @@ RCT_EXTERN void RCTVerifyAllModulesExported(NSArray *extraModules);
 
 @end
 
+@interface RCTBridge (Inspector)
+
+@property (nonatomic, readonly, getter=isInspectable) BOOL inspectable;
+
+@end
+
 @interface RCTBatchedBridge : RCTBridge <RCTInvalidating>
 
 @property (nonatomic, weak, readonly) RCTBridge *parentBridge;

diff --git a/React/CxxBridge/RCTCxxBridge.mm b/React/CxxBridge/RCTCxxBridge.mm
@@ -194,6 +194,10 @@ - (JSGlobalContextRef)jsContextRef
   return (JSGlobalContextRef)(self->_reactInstance ? self->_reactInstance->getJavaScriptContext() : nullptr);
 }
 
+- (BOOL)isInspectable {
+  return self->_reactInstance->isInspectable();
+}
+
 - (instancetype)initWithParentBridge:(RCTBridge *)bridge
 {
   RCTAssertParam(bridge);

diff --git a/ReactCommon/cxxreact/Instance.cpp b/ReactCommon/cxxreact/Instance.cpp
@@ -143,6 +143,10 @@ void *Instance::getJavaScriptContext() {
                            : nullptr;
 }
 
+bool Instance::isInspectable() {
+  return nativeToJsBridge_ ? nativeToJsBridge_->isInspectable() : false;
+}
+
 void Instance::callJSFunction(std::string &&module, std::string &&method,
                               folly::dynamic &&params) {
   callback_->incrementPendingJSCalls();

diff --git a/ReactCommon/cxxreact/Instance.h b/ReactCommon/cxxreact/Instance.h
@@ -55,6 +55,7 @@ class RN_EXPORT Instance {
   void setGlobalVariable(std::string propName,
                          std::unique_ptr<const JSBigString> jsonValue);
   void *getJavaScriptContext();
+  bool isInspectable();
   void callJSFunction(std::string &&module, std::string &&method,
                       folly::dynamic &&params);
   void callJSCallback(uint64_t callbackId, folly::dynamic &&params);

diff --git a/ReactCommon/cxxreact/NativeToJsBridge.cpp b/ReactCommon/cxxreact/NativeToJsBridge.cpp
@@ -190,6 +190,10 @@ void* NativeToJsBridge::getJavaScriptContext() {
   return m_executor->getJavaScriptContext();
 }
 
+bool NativeToJsBridge::isInspectable() {
+  return m_executor->isInspectable();
+}
+
 #ifdef WITH_JSC_MEMORY_PRESSURE
 void NativeToJsBridge::handleMemoryPressure(int pressureLevel) {
   runOnExecutorQueue([=] (JSExecutor* executor) {

diff --git a/ReactCommon/cxxreact/NativeToJsBridge.h b/ReactCommon/cxxreact/NativeToJsBridge.h
@@ -101,6 +101,7 @@ class NativeToJsBridge {
   void registerBundle(uint32_t bundleId, const std::string& bundlePath);
   void setGlobalVariable(std::string propName, std::unique_ptr<const JSBigString> jsonValue);
   void* getJavaScriptContext();
+  bool isInspectable();
 
   #ifdef WITH_JSC_MEMORY_PRESSURE
   void handleMemoryPressure(int pressureLevel);