Skip to content

Commit

Permalink
update xplat/js to flow 0.48.0
Browse files Browse the repository at this point in the history
Reviewed By: zertosh

Differential Revision: D5243415

fbshipit-source-id: 78ea4f7f29bcd6a70650f24ceb05f06b18b39018
  • Loading branch information
avikchaudhuri authored and facebook-github-bot committed Jun 14, 2017
1 parent 0d3b7fe commit 71401c1
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 7 deletions.
6 changes: 3 additions & 3 deletions .flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ suppress_type=$FlowIssue
suppress_type=$FlowFixMe
suppress_type=$FixMe

suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(4[0-7]\\|[1-3][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(4[0-7]\\|[1-3][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)?:? #[0-9]+
suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(4[0-8]\\|[1-3][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(4[0-8]\\|[1-3][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)?:? #[0-9]+
suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError

unsafe.enable_getters_and_setters=true

[version]
^0.47.0
^0.48.0
6 changes: 6 additions & 0 deletions RNTester/js/XHRExampleDownload.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,19 @@ class XHRExampleDownload extends React.Component {
}

const onreadystatechange = () => {
/* $FlowFixMe(>=0.48.0 site=react_native_fb,react_native_oss) This comment
* suppresses an error found when Flow v0.48 was deployed. To see the
* error delete this comment and run Flow. */
if (xhr.readyState === xhr.HEADERS_RECEIVED) {
const contentLength =
parseInt(xhr.getResponseHeader('Content-Length'), 10);
this.setState({
contentLength,
responseLength: 0,
});
/* $FlowFixMe(>=0.48.0 site=react_native_fb,react_native_oss) This comment
* suppresses an error found when Flow v0.48 was deployed. To see the
* error delete this comment and run Flow. */
} else if (xhr.readyState === xhr.LOADING && xhr.response) {
this.setState({
responseLength: xhr.response.length,
Expand Down
6 changes: 3 additions & 3 deletions local-cli/templates/HelloWorld/_flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ suppress_type=$FlowIssue
suppress_type=$FlowFixMe
suppress_type=$FixMe

suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(4[0-7]\\|[1-3][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(4[0-7]\\|[1-3][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+
suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(4[0-8]\\|[1-3][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(4[0-8]\\|[1-3][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+
suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError

unsafe.enable_getters_and_setters=true

[version]
^0.47.0
^0.48.0
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@
"eslint-plugin-babel": "^4.1.1",
"eslint-plugin-flowtype": "^2.33.0",
"eslint-plugin-react": "^7.0.1",
"flow-bin": "^0.47.0",
"flow-bin": "^0.48.0",
"jest": "^20.0.4",
"jest-repl": "^20.0.4",
"jest-runtime": "^20.0.4",
Expand Down

0 comments on commit 71401c1

Please sign in to comment.