Skip to content

Commit

Permalink
Update fresco to v1.8.1
Browse files Browse the repository at this point in the history
Summary:
<!--
  Required: Write your motivation here.
  If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
-->
The current version of fresco in use is [v1.3.0](https://github.com/facebook/fresco/releases/tag/v1.3.0) from April 2017. There has been a lot of [improvements](https://github.com/facebook/fresco/releases) since then.

Fresco also depends on OkHttp 3.8.0 and soloader 0.3.0 so I have updated these too. Let me know if there's any reason either of these shouldn't be updated, however this will prevent Fresco from being updated.

The latest version of OkHttp is 3.10.0, but I have kept it as low as possible to allow developers to choose the version.

<!--
  Required: Write your test plan here. If you changed any code, please provide us with
  clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
-->
Test with local build.
Check CI passes.

<!--
  Does this PR require a documentation change?
  Create a PR at https://github.com/facebook/react-native-website and add a link to it here.
-->

<!--
  Required.
  Help reviewers and the release process by writing your own release notes. See below for an example.
-->

[ANDROID] [ENHANCEMENT] [Fresco/OkHttp/SoLoader] - Updates Fresco to 1.8.1, OkHttp to 3.8.0, & SoLoader to 0.3.0

cc foghina

<!--
  **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**

    CATEGORY
  [----------]      TYPE
  [ CLI      ] [-------------]    LOCATION
  [ DOCS     ] [ BREAKING    ] [-------------]
  [ GENERAL  ] [ BUGFIX      ] [ {Component} ]
  [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]
  [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|
  [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |
  [----------] [-------------] [-------------]   |-----------|

 EXAMPLES:

 [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
 [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
 [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
 [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
 [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
 [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
-->
Closes facebook#18496

Differential Revision: D7361161

Pulled By: foghina

fbshipit-source-id: 6d2c5afb94ce5ff8e621188c2ac60f1ca4b787a6
  • Loading branch information
AndrewJack authored and facebook-github-bot committed Mar 22, 2018
1 parent 47910f0 commit 8e065ba
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 23 deletions.
10 changes: 5 additions & 5 deletions ReactAndroid/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -281,12 +281,12 @@ dependencies {
compile 'javax.inject:javax.inject:1'
compile 'com.android.support:appcompat-v7:23.0.1'
compile 'com.facebook.fbui.textlayoutbuilder:textlayoutbuilder:1.0.0'
compile 'com.facebook.fresco:fresco:1.3.0'
compile 'com.facebook.fresco:imagepipeline-okhttp3:1.3.0'
compile 'com.facebook.soloader:soloader:0.1.0'
compile 'com.facebook.fresco:fresco:1.8.1'
compile 'com.facebook.fresco:imagepipeline-okhttp3:1.8.1'
compile 'com.facebook.soloader:soloader:0.3.0'
compile 'com.google.code.findbugs:jsr305:3.0.0'
compile 'com.squareup.okhttp3:okhttp:3.6.0'
compile 'com.squareup.okhttp3:okhttp-urlconnection:3.6.0'
compile 'com.squareup.okhttp3:okhttp:3.8.0'
compile 'com.squareup.okhttp3:okhttp-urlconnection:3.8.0'
compile 'com.squareup.okio:okio:1.13.0'
compile 'org.webkit:android-jsc:r174650'

Expand Down
24 changes: 12 additions & 12 deletions ReactAndroid/src/main/libraries/fresco/fresco-react-native/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ rn_android_prebuilt_aar(

remote_file(
name = "fresco-binary-aar",
sha1 = "b6271dc58383b4ce119ecc05e2bcaedde0e74ad9",
url = "mvn:com.facebook.fresco:fresco:aar:1.3.0",
sha1 = "c6ed3f696ed47dca3b20d4ffbd0600c94b9119b2",
url = "mvn:com.facebook.fresco:fresco:aar:1.8.1",
)

android_prebuilt_aar(
Expand All @@ -20,8 +20,8 @@ android_prebuilt_aar(

remote_file(
name = "drawee-binary-aar",
sha1 = "c88fb84ed4ae8a4e0efe6fd3cad1a1d20c19ea69",
url = "mvn:com.facebook.fresco:drawee:aar:1.3.0",
sha1 = "6bc689901ddcac8f3df5ba4db1f8aabeb8e80107",
url = "mvn:com.facebook.fresco:drawee:aar:1.8.1",
)

rn_android_library(
Expand All @@ -42,8 +42,8 @@ rn_android_prebuilt_aar(

remote_file(
name = "imagepipeline-base-aar",
sha1 = "a43f1043fc684d2794438544f73f1968ec9cf21a",
url = "mvn:com.facebook.fresco:imagepipeline-base:aar:1.3.0",
sha1 = "42fd80c46a853850dfc0d71808b982fef401c841",
url = "mvn:com.facebook.fresco:imagepipeline-base:aar:1.8.1",
)

rn_android_prebuilt_aar(
Expand All @@ -54,8 +54,8 @@ rn_android_prebuilt_aar(

remote_file(
name = "imagepipeline-aar",
sha1 = "32c08122d47210d437f34eba5472e880b0f1e8b8",
url = "mvn:com.facebook.fresco:imagepipeline:aar:1.3.0",
sha1 = "06a2a4c3e1d9a7fb7d7f1ad14db63e2d32ef0b61",
url = "mvn:com.facebook.fresco:imagepipeline:aar:1.8.1",
)

rn_prebuilt_jar(
Expand All @@ -78,8 +78,8 @@ android_prebuilt_aar(

remote_file(
name = "fbcore-aar",
sha1 = "3b941157dd0c36fca9a19c22cae578f37deb97e5",
url = "mvn:com.facebook.fresco:fbcore:aar:1.3.0",
sha1 = "99b7a83946e16f037149e4cd3abfd6840a09445d",
url = "mvn:com.facebook.fresco:fbcore:aar:1.8.1",
)

android_prebuilt_aar(
Expand All @@ -90,6 +90,6 @@ android_prebuilt_aar(

remote_file(
name = "imagepipeline-okhttp3-binary-aar",
sha1 = "ac9b1a7c9906ed6be41c8df923a59f6952fce94c",
url = "mvn:com.facebook.fresco:imagepipeline-okhttp3:aar:1.3.0",
sha1 = "751f19412e1843b1c1e76eae46e388fb1deddbcc",
url = "mvn:com.facebook.fresco:imagepipeline-okhttp3:aar:1.8.1",
)
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ android_prebuilt_aar(

remote_file(
name = "soloader-binary-aar",
sha1 = "918573465c94c6bc9bad48ef259f1e0cd6543c1b",
url = "mvn:com.facebook.soloader:soloader:aar:0.1.0",
sha1 = "5f4b28f3c401f3d9bb2d081af08f6ce784a02da5",
url = "mvn:com.facebook.soloader:soloader:aar:0.3.0",
)
8 changes: 4 additions & 4 deletions ReactAndroid/src/main/third-party/java/okhttp/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ prebuilt_jar(

remote_file(
name = "okhttp3-binary-jar",
sha1 = "69edde9fc4b01c9fd51d25b83428837478c27254",
url = "mvn:com.squareup.okhttp3:okhttp:jar:3.6.0",
sha1 = "5a11f020cce2d11eb71ba916700600e18c4547e7",
url = "mvn:com.squareup.okhttp3:okhttp:jar:3.8.0",
)

prebuilt_jar(
Expand All @@ -18,6 +18,6 @@ prebuilt_jar(

remote_file(
name = "okhttp3-urlconnection-binary-jar",
sha1 = "3f9b16b774f2c36cfd86dd2053d0b3059531dacc",
url = "mvn:com.squareup.okhttp3:okhttp-urlconnection:jar:3.6.0",
sha1 = "265257b82f20bb0371a926cc8ceb5f7bb17c0df8",
url = "mvn:com.squareup.okhttp3:okhttp-urlconnection:jar:3.8.0",
)

0 comments on commit 8e065ba

Please sign in to comment.