Skip to content

Commit

Permalink
Broken publish step on CI
Browse files Browse the repository at this point in the history
Summary:
Every `job` is run in a separate container and so, `checkout` step is required for the Git host to be added to `~/.ssh/known_hosts`. Without this step, it will timeout after 10 minutes waiting for you to add (yes) or reject (no) from known hosts (we get this prompt when we checkout from a host for the very first time).
Closes facebook#17956

Differential Revision: D6968130

Pulled By: hramos

fbshipit-source-id: 6d62166fd375f8f408cf5f18b188f841d035d97f
  • Loading branch information
grabbou authored and facebook-github-bot committed Feb 12, 2018
1 parent f91f7d9 commit f7729a5
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -383,9 +383,9 @@ jobs:
publish_npm_package:
<<: *android_defaults
steps:
- attach_workspace:
at: ~/react-native

# Checkout code so that we can work with `git` in publish.js
- checkout
# Configure Android SDK and related dependencies
- run: *configure-android-path
- run: *install-android-build-dependencies
Expand Down Expand Up @@ -597,16 +597,12 @@ workflows:

# Only runs on NN-stable branches
deploy:
jobs:
# Checkout repo and run Yarn
- checkout_code:
filters: *filter-only-stable

jobs:
# If we are on a stable branch, wait for approval to deploy to npm
- approve_publish_npm_package:
filters: *filter-only-stable
type: approval

- publish_npm_package:
requires:
- checkout_code
- approve_publish_npm_package

0 comments on commit f7729a5

Please sign in to comment.