Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add lint checks in the primary ci workflow #16

Merged
merged 11 commits into from
Nov 1, 2022

Conversation

Tnation87
Copy link
Contributor

@Tnation87 Tnation87 commented Nov 1, 2022

Description

This PR adds a step to our primary Bitrise CI workflow that runs the lint checks command on the linta-android module.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Tnation87 Tnation87 requested review from a team and hfeky November 1, 2022 10:30
@jarvisswvl
Copy link
Collaborator

jarvisswvl commented Nov 1, 2022

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #16 (c66a657) into main (9ae6bf4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main      #16   +/-   ##
=========================================
  Coverage     95.04%   95.04%           
  Complexity       54       54           
=========================================
  Files             6        6           
  Lines           202      202           
  Branches         18       18           
=========================================
  Hits            192      192           
  Misses            2        2           
  Partials          8        8           
Impacted Files Coverage Δ
...id/src/main/java/com/swvl/lint/utils/ColorUtils.kt 87.87% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Tnation87 Tnation87 force-pushed the feat/add-lint-checks-to-primary-ci-workflow branch from 0f2293a to 9ae6bf4 Compare November 1, 2022 12:09
Copy link
Contributor

@hfeky hfeky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this! 🚀

@Tnation87 Tnation87 merged commit 543b23b into main Nov 1, 2022
@Tnation87 Tnation87 deleted the feat/add-lint-checks-to-primary-ci-workflow branch November 1, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants