Add --dep-as-jar option for idea-plugin (pantsbuild#8632)

sww · Nov 26, 2019 · 415538a · 415538a
1 parent 1b38c8f
commit 415538a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/python/pants/backend/project_info/tasks/idea_plugin_gen.py b/src/python/pants/backend/project_info/tasks/idea_plugin_gen.py
@@ -23,7 +23,7 @@
 _TEMPLATE_BASEDIR = 'templates/idea'
 
 # Follow `export.py` for versioning strategy.
-IDEA_PLUGIN_VERSION = '0.0.3'
+IDEA_PLUGIN_VERSION = '0.0.4'
 
 
 class IdeaPluginGen(ConsoleTask):
@@ -62,6 +62,8 @@ def register_options(cls, register):
     register('--incremental-import', type=int, default=None,
              help='Enable incremental import of targets with the given graph depth. Supported '
                   'by IntelliJ Pants plugin versions `>= 1.9.2`.')
+    register('--dep-as-jar', type=bool, default=False,
+             help='If true, treat source dependencies as 3rdparty jars.')
     register('--java-encoding', default='UTF-8',
              help='Sets the file encoding for java files in this project.')
     register('--open-with', type=str, default=None, recursive=True,
@@ -139,6 +141,7 @@ def generate_project(self):
       project_path=os.path.join(get_buildroot(), abs_target_specs[0].split(':')[0]),
       idea_plugin_version=IDEA_PLUGIN_VERSION,
       incremental_import=self.get_options().incremental_import,
+      dep_as_jar=self.get_options().dep_as_jar,
     )
 
     # Generate (without merging in any extra components).

diff --git a/src/python/pants/backend/project_info/tasks/templates/idea/workspace-12.mustache b/src/python/pants/backend/project_info/tasks/templates/idea/workspace-12.mustache
@@ -7,5 +7,6 @@
     {{#workspace.incremental_import?}}
     <property name="incremental_import" value="{{workspace.incremental_import}}" />
     {{/workspace.incremental_import?}}
+    <property name="dep_as_jar" value="{{workspace.dep_as_jar}}" />
   </component>
 </project>
diff --git a/tests/python/pants_test/backend/project_info/tasks/test_idea_plugin_integration.py b/tests/python/pants_test/backend/project_info/tasks/test_idea_plugin_integration.py
@@ -33,7 +33,8 @@ def _do_check(self, project_dir_path, expected_project_path, expected_targets,
         'targets',
         'project_path',
         'pants_idea_plugin_version',
-        'incremental_import'
+        'incremental_import',
+        'dep_as_jar'
       }
     self.assertTrue({p.getAttribute('name')
                      for p in actual_properties}.issubset(valid_property_names))