Skip to content

Commit

Permalink
Remove docgen from list of default packages, don't deprecate the --de…
Browse files Browse the repository at this point in the history
…fault-backend-packages option.

In https://rbcommons.com/s/twitter/r/3972/ we added this option but left it deprecated.  As per conversation on the pants-devel@ list, we don't want pants to be useless by default, so this change will allow this option to stay in place permanently, with the caveat that we are removing docgen from the list (mostly tasks only used to publish the Pants doc site.)

- Removes the docgen backend from the list of --default-backend-packages
- Removes the deprecation code around --default-backend-packages
- Updates our release scripting to add pants.backend.docgen back in for testing purposes
- Remove the `page()` target for the root README.md file to allow contrib packages to perform integration tests that don't bake in the docgen backend

Testing Done:
CI green at https://travis-ci.org/pantsbuild/pants/builds/136449213

Bugs closed: 3572

Reviewed at https://rbcommons.com/s/twitter/r/3988/
  • Loading branch information
ericzundel committed Jun 10, 2016
1 parent 5a59b2a commit 500dd5f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
4 changes: 0 additions & 4 deletions BUILD
Original file line number Diff line number Diff line change
@@ -1,4 +0,0 @@
# Copyright 2014 Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).

page(name="readme", source="README.md")
2 changes: 1 addition & 1 deletion build-support/bin/publish_docs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function do_open() {

# generate html from markdown pages.
${PANTS_EXE} markdown --fragment \
src:: examples:: contrib:: //:readme \
src:: examples:: contrib:: \
testprojects/src/java/org/pantsbuild/testproject/page:readme || \
die "Failed to generate HTML from markdown'."

Expand Down

0 comments on commit 500dd5f

Please sign in to comment.