Skip to content

Commit

Permalink
Annotate platform-specific tests in System.Text.Encoding.CodePages.Tests
Browse files Browse the repository at this point in the history 
A couple of the tests in System.Text.Encoding.CodePages.Tests depend on globalization support not yet implemented on Unix.  Disabling those for now.
  • Loading branch information
@stephentoub
stephentoub committed Apr 3, 2015
1 parent 2b25b8d commit 65cc742
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 12 deletions.
38 changes: 26 additions & 12 deletions src/System.Text.Encoding.CodePages/System.Text.Encoding.CodePages.sln
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "System.Text.Encoding.CodePa
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "System.Text.Encoding.CodePages.Tests", "tests\System.Text.Encoding.CodePages.Tests.csproj", "{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "XunitTraitsDiscoverers", "..\Common\tests\XunitTraitsDiscoverers\XunitTraitsDiscoverers.csproj", "{BE8ED8C1-C314-4C4E-A929-64C9C8B3552A}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Linux_Debug|Any CPU = Linux_Debug|Any CPU
Expand All @@ -29,18 +31,30 @@ Global
{16EE6633-F557-5C9E-9EF3-B5334B044F47}.Windows_Debug|Any CPU.Build.0 = Windows_Debug|Any CPU
{16EE6633-F557-5C9E-9EF3-B5334B044F47}.Windows_Release|Any CPU.ActiveCfg = Windows_Release|Any CPU
{16EE6633-F557-5C9E-9EF3-B5334B044F47}.Windows_Release|Any CPU.Build.0 = Windows_Release|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.Linux_Debug|Any CPU.ActiveCfg = Linux_Debug|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.Linux_Debug|Any CPU.Build.0 = Linux_Debug|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.Linux_Release|Any CPU.ActiveCfg = Linux_Release|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.Linux_Release|Any CPU.Build.0 = Linux_Release|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.OSX_Debug|Any CPU.ActiveCfg = OSX_Debug|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.OSX_Debug|Any CPU.Build.0 = OSX_Debug|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.OSX_Release|Any CPU.ActiveCfg = OSX_Release|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.OSX_Release|Any CPU.Build.0 = OSX_Release|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.Windows_Debug|Any CPU.ActiveCfg = Windows_Debug|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.Windows_Debug|Any CPU.Build.0 = Windows_Debug|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.Windows_Release|Any CPU.ActiveCfg = Windows_Release|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.Windows_Release|Any CPU.Build.0 = Windows_Release|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.Linux_Debug|Any CPU.ActiveCfg = Debug|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.Linux_Debug|Any CPU.Build.0 = Debug|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.Linux_Release|Any CPU.ActiveCfg = Release|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.Linux_Release|Any CPU.Build.0 = Release|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.OSX_Debug|Any CPU.ActiveCfg = Debug|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.OSX_Debug|Any CPU.Build.0 = Debug|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.OSX_Release|Any CPU.ActiveCfg = Release|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.OSX_Release|Any CPU.Build.0 = Release|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.Windows_Debug|Any CPU.ActiveCfg = Debug|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.Windows_Debug|Any CPU.Build.0 = Debug|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.Windows_Release|Any CPU.ActiveCfg = Release|Any CPU
{9574CEEC-5554-411B-B44C-6CA9EC1CEB08}.Windows_Release|Any CPU.Build.0 = Release|Any CPU
{BE8ED8C1-C314-4C4E-A929-64C9C8B3552A}.Linux_Debug|Any CPU.ActiveCfg = Debug|Any CPU
{BE8ED8C1-C314-4C4E-A929-64C9C8B3552A}.Linux_Debug|Any CPU.Build.0 = Debug|Any CPU
{BE8ED8C1-C314-4C4E-A929-64C9C8B3552A}.Linux_Release|Any CPU.ActiveCfg = Release|Any CPU
{BE8ED8C1-C314-4C4E-A929-64C9C8B3552A}.Linux_Release|Any CPU.Build.0 = Release|Any CPU
{BE8ED8C1-C314-4C4E-A929-64C9C8B3552A}.OSX_Debug|Any CPU.ActiveCfg = Debug|Any CPU
{BE8ED8C1-C314-4C4E-A929-64C9C8B3552A}.OSX_Debug|Any CPU.Build.0 = Debug|Any CPU
{BE8ED8C1-C314-4C4E-A929-64C9C8B3552A}.OSX_Release|Any CPU.ActiveCfg = Release|Any CPU
{BE8ED8C1-C314-4C4E-A929-64C9C8B3552A}.OSX_Release|Any CPU.Build.0 = Release|Any CPU
{BE8ED8C1-C314-4C4E-A929-64C9C8B3552A}.Windows_Debug|Any CPU.ActiveCfg = Debug|Any CPU
{BE8ED8C1-C314-4C4E-A929-64C9C8B3552A}.Windows_Debug|Any CPU.Build.0 = Debug|Any CPU
{BE8ED8C1-C314-4C4E-A929-64C9C8B3552A}.Windows_Release|Any CPU.ActiveCfg = Release|Any CPU
{BE8ED8C1-C314-4C4E-A929-64C9C8B3552A}.Windows_Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down
2 changes: 2 additions & 0 deletions src/System.Text.Encoding.CodePages/tests/EncodingCodePages.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ public CodePageToWebNameMapping(int codePage, string webName)
}

[Fact]
[ActiveIssue(846, PlatformID.Linux | PlatformID.OSX)]
public static void TestDefaultCodePage()
{

Expand Down Expand Up @@ -99,6 +100,7 @@ private static void TestRoundtrippingCodepageEncoding(string encodingName, byte[
}

[Fact]
[ActiveIssue(846, PlatformID.Linux | PlatformID.OSX)]
public static void TestSpecificCodepageEncodings()
{
EnsureInitialization();
Expand Down

0 comments on commit 65cc742

Please sign in to comment.