Skip to content

Commit

Permalink
Fix FileVersionInfo test for CompanyName
Browse files Browse the repository at this point in the history
Code coverage highlighted that we had a bug in VerifyVersionInfo where the test for CompanyName was actually testing Comments.  Fixing that then highlighted a bug in the test data when compared to the actual native DLL.
  • Loading branch information
stephentoub committed Jun 4, 2015
1 parent 41b90e6 commit ef2fe64
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public void FileVersionInfo_Normal()
VerifyVersionInfo(Path.Combine(Directory.GetCurrentDirectory(), NativeConsoleAppFileName), new MyFVI()
{
Comments = "",
CompanyName = "This is not a real company name.",
CompanyName = "Microsoft Corporation",
FileBuildPart = 3,
FileDescription = "This is the description for the native console application.",
FileMajorPart = 5,
Expand Down Expand Up @@ -217,7 +217,7 @@ private void VerifyVersionInfo(String filePath, MyFVI expected)
{
FileVersionInfo fvi = FileVersionInfo.GetVersionInfo(filePath);
TestStringProperty("Comments", fvi.Comments, expected.Comments);
TestStringProperty("CompanyName", fvi.Comments, expected.Comments);
TestStringProperty("CompanyName", fvi.CompanyName, expected.CompanyName);
TestProperty<int>("FileBuildPart", fvi.FileBuildPart, expected.FileBuildPart);
TestStringProperty("FileDescription", fvi.FileDescription, expected.FileDescription);
TestProperty<int>("FileMajorPart", fvi.FileMajorPart, expected.FileMajorPart);
Expand Down

0 comments on commit ef2fe64

Please sign in to comment.