Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explorer] fix: remove database field in node status with non API roles #1195

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

AnthonyLaw
Copy link
Member

@AnthonyLaw AnthonyLaw commented Dec 26, 2024

problem: non-API roles display Data Base status in node status.
solution: check on the node roles, Data Base only displays node contain API roles.

Before:
image

After:
image

@AnthonyLaw AnthonyLaw requested a review from Wayonb December 26, 2024 09:33
Copy link

netlify bot commented Dec 26, 2024

Deploy Preview for explorer-dev ready!

Name Link
🔨 Latest commit 236353a
🔍 Latest deploy log https://app.netlify.com/sites/explorer-dev/deploys/677e300680216e0008c6bc6b
😎 Deploy Preview https://deploy-preview-1195--explorer-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/infrastructure/NodeService.js Outdated Show resolved Hide resolved
src/infrastructure/NodeService.js Show resolved Hide resolved
@AnthonyLaw AnthonyLaw force-pushed the fix/remove-database-field branch from d538439 to 811cfce Compare January 8, 2025 06:27
@AnthonyLaw AnthonyLaw requested a review from Wayonb January 8, 2025 09:16
Copy link
Contributor

@Wayonb Wayonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@AnthonyLaw AnthonyLaw merged commit 7ef06fe into dev Jan 13, 2025
7 checks passed
@AnthonyLaw AnthonyLaw deleted the fix/remove-database-field branch January 13, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants