-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mailer] Document require_tls
option
#20701
Open
ssddanbrown
wants to merge
3
commits into
symfony:7.3
Choose a base branch
from
ssddanbrown:mailer_document_require_tls_option
base: 7.3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -420,6 +420,29 @@ setting the ``auto_tls`` option to ``false`` in the DSN:: | |
|
||
This setting only works when the ``smtp://`` protocol is used. | ||
|
||
Require use of TLS | ||
~~~~~~~~~~~~~~~~~~ | ||
|
||
You may want to ensure TLS is used, either directly or via ``STARTTLS``, | ||
for sending mail over SMTP regardless of other options set or SMTP server | ||
support. You can set TLS as required by calling ``setRequireTls(true)`` | ||
on the ``EsmtpTransport`` instance, or by setting the ``require_tls`` option | ||
to ``true`` in the DSN:: | ||
|
||
$dsn = 'smtp://user:[email protected]?require_tls=true'; | ||
|
||
When TLS is set as required, a :class:`Symfony\\Component\\Mailer\\Exception\\TransportException` | ||
will be thrown if a TLS connection cannot be achieved during initial communications | ||
with the SMTP server. | ||
|
||
.. note:: | ||
|
||
This setting only works when the ``smtp://`` protocol is used. | ||
|
||
.. versionadded:: 7.3 | ||
|
||
The ``require_tls`` option was introduced in Symfony 7.3. | ||
|
||
Binding to IPv4 or IPv6 | ||
~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to change if preferred, but
Enforce
feels slightly less accurate to me.Enforce
sounds like it'd change/force the connection in some manner and/or force TLS upon the whole connection process, whereas this option doesn't change the connection in any way, just ensures it's eventually used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand your concern about the term "Enforce" and I agree with you.
What do you think about "Ensure TLS" instead? It might better reflect that the option guarantees the use of TLS without actively altering the connection.