Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix phpclass reference with namespaces #20822

Closed
wants to merge 1 commit into from
Closed

fix phpclass reference with namespaces #20822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions serializer.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1388,12 +1388,12 @@
want ``null`` instead, you can set the ``BackedEnumNormalizer::ALLOW_INVALID_VALUES`` option.

:class:`Symfony\\Component\\Serializer\\Normalizer\\NumberNormalizer`
This normalizer converts between :phpclass:`BcMath\\Number` or :phpclass:`GMP` objects and
This normalizer converts between :phpclass:`BcMath\Number` or :phpclass:`GMP` objects and

Check failure on line 1391 in serializer.rst

View workflow job for this annotation

GitHub Actions / Lint (DOCtor-RST) 

Please use 2 backslashes when highlighting a namespace with single backticks: `BcMath\Number`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OskarStark Does doctor-rst require an update to also handle symfony-tools/docs-builder#190?

Copy link
Contributor

@OskarStark OskarStark Mar 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why class requires double slash, but phpclass doesn't. Don't they use the exact same rst feature?

strings or integers.

.. versionadded:: 7.2
.. versionadded:: 7.3

The ``NumberNormalizer`` was introduced in Symfony 7.2.
The ``NumberNormalizer`` was introduced in Symfony 7.3.

:class:`Symfony\\Component\\Serializer\\Normalizer\\DataUriNormalizer`
This normalizer converts between :phpclass:`SplFileInfo` objects and a
Expand Down