-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[CUDA][HIP] allow trivial ctor/dtor in device var init (#73140)
Treat ctor/dtor in device var init as host device function so that they can be used to initialize file-scope device variables to match nvcc behavior. If they are non-trivial they will be diagnosed. We cannot add implicit host device attrs to non-trivial ctor/dtor since determining whether they are non-trivial needs to know whether they have a trivial body and all their member and base classes' ctor/dtor have trivial body, which is affected by where their bodies are defined or instantiated. Fixes: #72261 Fixes: SWDEV-432412
- Loading branch information
Showing
2 changed files
with
66 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
// RUN: %clang_cc1 -isystem %S/Inputs -fsyntax-only -verify %s | ||
// RUN: %clang_cc1 -isystem %S/Inputs -fcuda-is-device -fsyntax-only -verify %s | ||
|
||
#include <cuda.h> | ||
|
||
// Check trivial ctor/dtor | ||
struct A { | ||
int x; | ||
A() {} | ||
~A() {} | ||
}; | ||
|
||
__device__ A a; | ||
|
||
// Check trivial ctor/dtor of template class | ||
template<typename T> | ||
struct TA { | ||
T x; | ||
TA() {} | ||
~TA() {} | ||
}; | ||
|
||
__device__ TA<int> ta; | ||
|
||
// Check non-trivial ctor/dtor in parent template class | ||
template<typename T> | ||
struct TB { | ||
T x; | ||
TB() { static int nontrivial_ctor = 1; } | ||
~TB() {} | ||
}; | ||
|
||
template<typename T> | ||
struct TC : TB<T> { | ||
T x; | ||
TC() {} | ||
~TC() {} | ||
}; | ||
|
||
template class TC<int>; | ||
|
||
__device__ TC<int> tc; //expected-error {{dynamic initialization is not supported for __device__, __constant__, __shared__, and __managed__ variables}} | ||
|
||
// Check trivial ctor specialization | ||
template <typename T> | ||
struct C { | ||
explicit C() {}; | ||
}; | ||
|
||
template <> C<int>::C() {}; | ||
__device__ C<int> ci_d; | ||
C<int> ci_h; | ||
|
||
// Check non-trivial ctor specialization | ||
template <> C<float>::C() { static int nontrivial_ctor = 1; } | ||
__device__ C<float> cf_d; //expected-error {{dynamic initialization is not supported for __device__, __constant__, __shared__, and __managed__ variables}} | ||
C<float> cf_h; |