commands: remove --show-json/--show-md/--show-csv flags (iterative#9475)

syo093c · May 18, 2023 · 90aaf5a · 90aaf5a
1 parent 45c5c83
commit 90aaf5a
Show file tree

Hide file tree

Showing 12 changed files with 0 additions and 46 deletions.
diff --git a/dvc/commands/dag.py b/dvc/commands/dag.py
@@ -176,7 +176,6 @@ def add_parser(subparsers, parent_parser):
     )
     dag_parser.add_argument(
         "--md",
-        "--show-md",
         action="store_true",
         default=False,
         dest="markdown",

diff --git a/dvc/commands/data.py b/dvc/commands/data.py
@@ -217,13 +217,6 @@ def add_parser(subparsers, parent_parser):
         default=False,
         help="Show output in JSON format.",
     )
-    data_status_parser.add_argument(
-        "--show-json",
-        action="store_true",
-        default=False,
-        dest="json",
-        help=argparse.SUPPRESS,
-    )
     data_status_parser.add_argument(
         "--granular",
         action="store_true",
@@ -269,7 +262,6 @@ def add_parser(subparsers, parent_parser):
     )
     data_ls_parser.add_argument(
         "--md",
-        "--show-md",
         dest="markdown",
         action="store_true",
         default=False,

diff --git a/dvc/commands/data_sync.py b/dvc/commands/data_sync.py
@@ -403,7 +403,6 @@ def add_parser(subparsers, _parent_parser):
     )
     status_parser.add_argument(
         "--json",
-        "--show-json",
         action="store_true",
         default=False,
         help="Show status in JSON format.",

diff --git a/dvc/commands/diff.py b/dvc/commands/diff.py
@@ -184,7 +184,6 @@ def add_parser(subparsers, parent_parser):
     )
     diff_parser.add_argument(
         "--json",
-        "--show-json",
         help="Format the output into a JSON",
         action="store_true",
         default=False,
@@ -197,7 +196,6 @@ def add_parser(subparsers, parent_parser):
     )
     diff_parser.add_argument(
         "--md",
-        "--show-md",
         help="Show tabulated output in the Markdown format (GFM).",
         action="store_true",
         dest="markdown",

diff --git a/dvc/commands/experiments/diff.py b/dvc/commands/experiments/diff.py
@@ -83,14 +83,12 @@ def add_parser(experiments_subparsers, parent_parser):
     )
     experiments_diff_parser.add_argument(
         "--json",
-        "--show-json",
         action="store_true",
         default=False,
         help="Show output in JSON format.",
     )
     experiments_diff_parser.add_argument(
         "--md",
-        "--show-md",
         action="store_true",
         default=False,
         dest="markdown",

diff --git a/dvc/commands/experiments/save.py b/dvc/commands/experiments/save.py
@@ -53,7 +53,6 @@ def add_parser(experiments_subparsers, parent_parser):
     )
     save_parser.add_argument(
         "--json",
-        "--show-json",
         action="store_true",
         default=False,
         help="Show output in JSON format.",

diff --git a/dvc/commands/experiments/show.py b/dvc/commands/experiments/show.py
@@ -316,21 +316,18 @@ def add_parser(experiments_subparsers, parent_parser):
     )
     experiments_show_parser.add_argument(
         "--json",
-        "--show-json",
         action="store_true",
         default=False,
         help="Print output in JSON format instead of a human-readable table.",
     )
     experiments_show_parser.add_argument(
         "--csv",
-        "--show-csv",
         action="store_true",
         default=False,
         help="Print output in csv format instead of a human-readable table.",
     )
     experiments_show_parser.add_argument(
         "--md",
-        "--show-md",
         action="store_true",
         default=False,
         dest="markdown",

diff --git a/dvc/commands/ls/__init__.py b/dvc/commands/ls/__init__.py
@@ -71,7 +71,6 @@ def add_parser(subparsers, parent_parser):
     )
     list_parser.add_argument(
         "--json",
-        "--show-json",
         action="store_true",
         help="Show output in JSON format.",
     )

diff --git a/dvc/commands/metrics.py b/dvc/commands/metrics.py
@@ -140,14 +140,12 @@ def add_parser(subparsers, parent_parser):
     )
     metrics_show_parser.add_argument(
         "--json",
-        "--show-json",
         action="store_true",
         default=False,
         help="Show output in JSON format.",
     )
     metrics_show_parser.add_argument(
         "--md",
-        "--show-md",
         action="store_true",
         default=False,
         dest="markdown",
@@ -223,14 +221,12 @@ def add_parser(subparsers, parent_parser):
     )
     metrics_diff_parser.add_argument(
         "--json",
-        "--show-json",
         action="store_true",
         default=False,
         help="Show output in JSON format.",
     )
     metrics_diff_parser.add_argument(
         "--md",
-        "--show-md",
         action="store_true",
         default=False,
         dest="markdown",

diff --git a/dvc/commands/params.py b/dvc/commands/params.py
@@ -105,14 +105,12 @@ def add_parser(subparsers, parent_parser):
     )
     params_diff_parser.add_argument(
         "--json",
-        "--show-json",
         action="store_true",
         default=False,
         help="Show output in JSON format.",
     )
     params_diff_parser.add_argument(
         "--md",
-        "--show-md",
         action="store_true",
         default=False,
         dest="markdown",

diff --git a/dvc/commands/plots.py b/dvc/commands/plots.py
@@ -430,7 +430,6 @@ def _add_ui_arguments(parser):
     )
     parser.add_argument(
         "--json",
-        "--show-json",
         action="store_true",
         default=False,
         help=argparse.SUPPRESS,

diff --git a/tests/unit/command/test_compat_flag.py b/tests/unit/command/test_compat_flag.py
@@ -14,28 +14,8 @@ def _id_gen(val) -> str:
 @pytest.mark.parametrize(
     "args, key",
     [
-        (["dag", "--show-md"], "markdown"),
-        (["data", "ls", "--show-md"], "markdown"),
-        (["diff", "--show-json"], "json"),
-        (["diff", "--show-md"], "markdown"),
-        (["experiments", "diff", "--show-json"], "json"),
-        (["experiments", "diff", "--show-md"], "markdown"),
-        (["experiments", "show", "--show-json"], "json"),
-        (["experiments", "show", "--show-csv"], "csv"),
-        (["experiments", "show", "--show-md"], "markdown"),
-        (["ls", "--show-json", "."], "json"),
-        (["metrics", "diff", "--show-json"], "json"),
-        (["metrics", "diff", "--show-md"], "markdown"),
-        (["metrics", "show", "--show-json"], "json"),
-        (["metrics", "show", "--show-md"], "markdown"),
-        (["params", "diff", "--show-json"], "json"),
-        (["params", "diff", "--show-md"], "markdown"),
-        (["status", "--show-json"], "json"),
-        (["plots", "show", "--show-json"], "json"),
-        (["plots", "diff", "--show-json"], "json"),
         (["exp", "list", "--names-only"], "name_only"),
         (["stage", "list", "--names-only"], "name_only"),
-        (["data", "status", "--json"], "json"),
     ],
     ids=_id_gen,
 )