Skip to content

Commit

Permalink
lib:printer_driver: Don't overwrite printprocessor
Browse files Browse the repository at this point in the history
If the printprocessor is parsed from the inf file in the codepath:

setup_driver_name
  find_driver_files
    process_driver_section_printprocessor

Don't overwrite the value later on in setup_driver_name with the default "winprint"

Signed-off-by: Justin Stephenson <[email protected]>
Reviewed-by: Andreas Schneider <[email protected]>
Reviewed-by: Bjoern Jacke <[email protected]>
  • Loading branch information
justin-stephenson authored and Bjoern Jacke committed Jan 28, 2019
1 parent 1663801 commit 5442355
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions lib/printer_driver/printer_driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -1027,9 +1027,11 @@ static NTSTATUS setup_driver_by_name(TALLOC_CTX *mem_ctx,
return NT_STATUS_NO_MEMORY;
}

r->print_processor = talloc_strdup(mem_ctx, "winprint");
if (r->print_processor == NULL) {
return NT_STATUS_NO_MEMORY;
r->print_processor = talloc_strdup(mem_ctx, "winprint");
if (r->print_processor == NULL) {
return NT_STATUS_NO_MEMORY;
}
}

status = gp_inifile_getstring(ctx, "Version:Signature", &s);
Expand Down

0 comments on commit 5442355

Please sign in to comment.