fix inactive queue pop from the wrong end

t-8ch · Jan 31, 2022 · f1ca659 · f1ca659
1 parent b5a242b
commit f1ca659
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/spyne/server/twisted/msgpack.py b/spyne/server/twisted/msgpack.py
@@ -124,7 +124,7 @@ def __init__(self, tpt, max_buffer_size=2 * 1024 * 1024, out_chunk_size=0,
         self.idle_timer = None
         self.out_chunks = deque()
         self.inreq_queue = OrderedDict()
-        self.inactive_queue = list()
+        self.inactive_queue = deque()
         self.disconnecting = False  # FIXME: should we use this to raise an
                                     # invalid connection state exception ?
 
@@ -163,7 +163,7 @@ def connectionMade(self):
         self.idle_timer = None
         self.out_chunks = deque()
         self.inreq_queue = OrderedDict()
-        self.inactive_queue = list()
+        self.inactive_queue = deque()
         self.active_queue = dict()
         self.disconnecting = False  # FIXME: should we use this to raise an
                                     # invalid connection state exception ?
@@ -269,7 +269,7 @@ def process_inactive(self):
 
         if self.max_in_queue_size == 0:
             while self.num_inactive_contexts > 0:
-                p_ctx, others = self.inactive_queue.pop()
+                p_ctx, others = self.inactive_queue.popleft()
                 self.active_queue[id(p_ctx)] = p_ctx
 
                 self.inreq_queue[id(p_ctx)] = None
@@ -278,7 +278,7 @@ def process_inactive(self):
         else:
             while self.num_active_contexts < self.max_in_queue_size and \
                                                  self.num_inactive_contexts > 0:
-                p_ctx, others = self.inactive_queue.pop()
+                p_ctx, others = self.inactive_queue.popleft()
                 self.active_queue[id(p_ctx)] = p_ctx
 
                 self.inreq_queue[id(p_ctx)] = None