-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle 413 Request Entity Too Large #608
Merged
jakeichikawasalesforce
merged 21 commits into
master
from
jichikawa/handle-413-payload-response
May 23, 2023
Merged
Handle 413 Request Entity Too Large #608
jakeichikawasalesforce
merged 21 commits into
master
from
jichikawa/handle-413-payload-response
May 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antesaj
approved these changes
May 22, 2023
dleskosky
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tornado has
max_body_size
as the largest response body that the client will accept, but the resulting code path does not respond with an HTTP error code of 413. By default, Tornado checks thecontent-length
header in HTTP1Connection._read_body and raises an error if it exceeds the limit; the request handler code is never executed.This PR overrides HTTP1Connection._read_body to allow requests that are too large to continue on to the handler. We then handle this scenario (Request Entity Too Large) in the base_handler with request_body_size_within_limit. This method is called at the beginning of each GET or POST request in the evaluation and query plane handlers.