Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 413 Request Entity Too Large #608

Merged
merged 21 commits into from
May 23, 2023

Conversation

jakeichikawasalesforce
Copy link
Collaborator

Tornado has max_body_size as the largest response body that the client will accept, but the resulting code path does not respond with an HTTP error code of 413. By default, Tornado checks the content-length header in HTTP1Connection._read_body and raises an error if it exceeds the limit; the request handler code is never executed.

This PR overrides HTTP1Connection._read_body to allow requests that are too large to continue on to the handler. We then handle this scenario (Request Entity Too Large) in the base_handler with request_body_size_within_limit. This method is called at the beginning of each GET or POST request in the evaluation and query plane handlers.

@jakeichikawasalesforce jakeichikawasalesforce changed the title Draft: Handle 413 Request Entity Too Large Handle 413 Request Entity Too Large May 22, 2023
@jakeichikawasalesforce jakeichikawasalesforce merged commit 5716a67 into master May 23, 2023
@jakeichikawasalesforce jakeichikawasalesforce deleted the jichikawa/handle-413-payload-response branch May 23, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants