Skip to content

Commit

Permalink
HOME must be set before calling git-init when creating test repositories
Browse files Browse the repository at this point in the history
Otherwise the created test repositories will be affected by users ~/.gitconfig.
For example, setting core.logAllrefupdates in users config will make all
calls to "git config --unset core.logAllrefupdates" fail which will break
the first test which uses the statement and expects it to succeed.

Signed-off-by: Alex Riesen <[email protected]>
Acked-by: Jeff King <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
raalkml authored and gitster committed Mar 29, 2011
1 parent f1723ee commit 90cff96
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions t/test-lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -1004,14 +1004,14 @@ rm -fr "$test" || {
exit 1
}

HOME="$TRASH_DIRECTORY"
export HOME

test_create_repo "$test"
# Use -P to resolve symlinks in our working directory so that the cwd
# in subprocesses like git equals our $PWD (for pathname comparisons).
cd -P "$test" || exit 1

HOME=$(pwd)
export HOME

this_test=${0##*/}
this_test=${this_test%%-*}
for skp in $GIT_SKIP_TESTS
Expand Down

0 comments on commit 90cff96

Please sign in to comment.