Skip to content

Commit

Permalink
drm/i915/display/atomic_plane: Prefer drm_WARN_ON over WARN_ON
Browse files Browse the repository at this point in the history
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.

Prefer drm_WARN_ON over WARN_ON.

Signed-off-by: Pankaj Bharadiya <[email protected]>
Signed-off-by: Jani Nikula <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
  • Loading branch information
bpankajl authored and jnikula committed Apr 21, 2020
1 parent 61198fe commit 1e6850e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/gpu/drm/i915/display/intel_atomic_plane.c
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ intel_plane_destroy_state(struct drm_plane *plane,
struct drm_plane_state *state)
{
struct intel_plane_state *plane_state = to_intel_plane_state(state);
WARN_ON(plane_state->vma);
drm_WARN_ON(plane->dev, plane_state->vma);

__drm_atomic_helper_plane_destroy_state(&plane_state->uapi);
if (plane_state->hw.fb)
Expand Down Expand Up @@ -396,7 +396,7 @@ skl_next_plane_to_commit(struct intel_atomic_state *state,
}

/* should never happen */
WARN_ON(1);
drm_WARN_ON(state->base.dev, 1);

return NULL;
}
Expand Down

0 comments on commit 1e6850e

Please sign in to comment.