Skip to content

Commit

Permalink
media: imx: csi: Implement get_fwnode_pad op
Browse files Browse the repository at this point in the history
The CSI does not have a 1:1 relationship between fwnode port numbers and
pad indexes. In fact the CSI fwnode device is itself a port which is the
sink, containing only a single fwnode endpoint. Implement media_entity
operation get_fwnode_pad to first verify the given endpoint is the CSI's
sink endpoint, and if so return the CSI sink pad index.

Signed-off-by: Steve Longerbeam <[email protected]>
Reviewed-by: Laurent Pinchart <[email protected]>
Signed-off-by: Sakari Ailus <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
  • Loading branch information
slongerbeam authored and mchehab committed May 18, 2020
1 parent acee603 commit 596e5c5
Showing 1 changed file with 23 additions and 0 deletions.
23 changes: 23 additions & 0 deletions drivers/staging/media/imx/imx-media-csi.c
Original file line number Diff line number Diff line change
Expand Up @@ -1832,9 +1832,32 @@ static void csi_unregistered(struct v4l2_subdev *sd)
ipu_csi_put(priv->csi);
}

/*
* The CSI has only one fwnode endpoint, at the sink pad. Verify the
* endpoint belongs to us, and return CSI_SINK_PAD.
*/
static int csi_get_fwnode_pad(struct media_entity *entity,
struct fwnode_endpoint *endpoint)
{
struct v4l2_subdev *sd = media_entity_to_v4l2_subdev(entity);
struct csi_priv *priv = v4l2_get_subdevdata(sd);
struct fwnode_handle *csi_port = dev_fwnode(priv->dev);
struct fwnode_handle *csi_ep;
int ret;

csi_ep = fwnode_get_next_child_node(csi_port, NULL);

ret = endpoint->local_fwnode == csi_ep ? CSI_SINK_PAD : -ENXIO;

fwnode_handle_put(csi_ep);

return ret;
}

static const struct media_entity_operations csi_entity_ops = {
.link_setup = csi_link_setup,
.link_validate = v4l2_subdev_link_validate,
.get_fwnode_pad = csi_get_fwnode_pad,
};

static const struct v4l2_subdev_core_ops csi_core_ops = {
Expand Down

0 comments on commit 596e5c5

Please sign in to comment.