Skip to content

Commit

Permalink
gpio: exar: switch to a simpler IDA interface
Browse files Browse the repository at this point in the history
We don't need to specify any ranges when allocating IDs so we can switch
to ida_alloc() and ida_free() instead of the ida_simple_ counterparts.

ida_simple_get(ida, 0, 0, gfp) is equivalent to
ida_alloc_range(ida, 0, UINT_MAX, gfp) which is equivalent to
ida_alloc(ida, gfp). Note: IDR will never actually allocate an ID
larger than INT_MAX.

Signed-off-by: Bartosz Golaszewski <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
  • Loading branch information
brgl committed Nov 25, 2020
1 parent 26ced45 commit 8e27c2a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/gpio/gpio-exar.c
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ static int gpio_exar_probe(struct platform_device *pdev)

mutex_init(&exar_gpio->lock);

index = ida_simple_get(&ida_index, 0, 0, GFP_KERNEL);
index = ida_alloc(&ida_index, GFP_KERNEL);
if (index < 0) {
ret = index;
goto err_mutex_destroy;
Expand Down Expand Up @@ -179,7 +179,7 @@ static int gpio_exar_probe(struct platform_device *pdev)
return 0;

err_destroy:
ida_simple_remove(&ida_index, index);
ida_free(&ida_index, index);
err_mutex_destroy:
mutex_destroy(&exar_gpio->lock);
return ret;
Expand All @@ -189,7 +189,7 @@ static int gpio_exar_remove(struct platform_device *pdev)
{
struct exar_gpio_chip *exar_gpio = platform_get_drvdata(pdev);

ida_simple_remove(&ida_index, exar_gpio->index);
ida_free(&ida_index, exar_gpio->index);
mutex_destroy(&exar_gpio->lock);

return 0;
Expand Down

0 comments on commit 8e27c2a

Please sign in to comment.