watchdog: iTCO_wdt: Fix detection of SMI-off case

Obviously, the test needs to run against the register content, not its address. Fixes: cb01104 ("watchdog: iTCO_wdt: Account for rebooting on second timeout") Cc: [email protected] Reported-by: Mantas Mikulėnas <[email protected]> Signed-off-by: Jan Kiszka <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Reviewed-by: Guenter Roeck <[email protected]> Tested-by: Mantas Mikulėnas <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Guenter Roeck <[email protected]> Signed-off-by: Wim Van Sebroeck <[email protected]>
tadfisher · Aug 22, 2021 · aec4264 · aec4264
1 parent a4f9581
commit aec4264
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
@@ -362,7 +362,7 @@ static int iTCO_wdt_set_timeout(struct watchdog_device *wd_dev, unsigned int t)
 	 * Otherwise, the BIOS generally reboots when the SMI triggers.
 	 */
 	if (p->smi_res &&
-	    (SMI_EN(p) & (TCO_EN | GBL_SMI_EN)) != (TCO_EN | GBL_SMI_EN))
+	    (inl(SMI_EN(p)) & (TCO_EN | GBL_SMI_EN)) != (TCO_EN | GBL_SMI_EN))
 		tmrval /= 2;
 
 	/* from the specs: */