Skip to content

Commit

Permalink
gpio: logicvc: Remove redundant error printing in logicvc_gpio_probe()
Browse files Browse the repository at this point in the history
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zhen Lei <[email protected]>
Signed-off-by: Bartosz Golaszewski <[email protected]>
  • Loading branch information
Zhen Lei authored and brgl committed May 12, 2021
1 parent 63c4acf commit c35fb57
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/gpio/gpio-logicvc.c
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,8 @@ static int logicvc_gpio_probe(struct platform_device *pdev)
}

base = devm_ioremap_resource(dev, &res);
if (IS_ERR(base)) {
dev_err(dev, "Failed to map I/O base\n");
if (IS_ERR(base))
return PTR_ERR(base);
}

logicvc_gpio_regmap_config.max_register = resource_size(&res) -
logicvc_gpio_regmap_config.reg_stride;
Expand Down

0 comments on commit c35fb57

Please sign in to comment.