Skip to content

Commit

Permalink
media: imx: TODO: Remove media link creation todos
Browse files Browse the repository at this point in the history
Remove the TODO items regarding media link creation, these issues are
resolved by moving media link creation to individual entity bound
callbacks and the implementation of the get_fwnode_pad operation.

Signed-off-by: Steve Longerbeam <[email protected]>
Signed-off-by: Sakari Ailus <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
  • Loading branch information
slongerbeam authored and mchehab committed May 18, 2020
1 parent 50da3f3 commit c4e0536
Showing 1 changed file with 0 additions and 29 deletions.
29 changes: 0 additions & 29 deletions drivers/staging/media/imx/TODO
Original file line number Diff line number Diff line change
Expand Up @@ -17,35 +17,6 @@
decided whether this feature is useful enough to make it generally
available by exporting to v4l2-core.

- After all async subdevices have been bound, v4l2_fwnode_parse_link()
is used to form the media links between the devices discovered in
the OF graph.

While this approach allows support for arbitrary OF graphs, there
are some assumptions for this to work:

1. If a port owned by a device in the graph has endpoint nodes, the
port is treated as a media pad.

This presents problems for devices that don't make this port = pad
assumption. Examples are SMIAPP compatible cameras which define only
a single output port node, but which define multiple pads owned
by multiple subdevices (pixel-array, binner, scaler). Or video
decoders (entity function MEDIA_ENT_F_ATV_DECODER), which also define
only a single output port node, but define multiple pads for video,
VBI, and audio out.

A workaround at present is to set the port reg properties to
correspond to the media pad index that the port represents. A
possible long-term solution is to implement a subdev API that
maps a port id to a media pad index.

2. Every endpoint of a port owned by a device in the graph is treated
as a media link.

Which means a port must not contain mixed-use endpoints, they
must all refer to media links between V4L2 subdevices.

- i.MX7: all of the above, since it uses the imx media core

- i.MX7: use Frame Interval Monitor
Expand Down

0 comments on commit c4e0536

Please sign in to comment.