pcmcia/electra_cf: Fix some return values in 'electra_cf_probe()' in …

…case of error 'status' is known to be 0 at this point. It must be set to a meaningful value in order to return an error code if one of the 'of_get_property()' call fails. Return -EINVAL in such a case. Fixes: 2b571a0("pcmcia: CompactFlash driver for PA Semi Electra boards") Signed-off-by: Christophe JAILLET <[email protected]> Acked-by: Olof Johansson <[email protected]> Signed-off-by: Dominik Brodowski <[email protected]>
tadfisher · Dec 5, 2020 · f15480e · f15480e
1 parent b329850
commit f15480e
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/drivers/pcmcia/electra_cf.c b/drivers/pcmcia/electra_cf.c
@@ -229,6 +229,8 @@ static int electra_cf_probe(struct platform_device *ofdev)
 
 	cf->socket.pci_irq = cf->irq;
 
+	status = -EINVAL;
+
 	prop = of_get_property(np, "card-detect-gpio", NULL);
 	if (!prop)
 		goto fail1;