Skip to content

Commit

Permalink
KVM: arm/arm64: Ensure only THP is candidate for adjustment
Browse files Browse the repository at this point in the history
PageTransCompoundMap() returns true for hugetlbfs and THP
hugepages. This behaviour incorrectly leads to stage 2 faults for
unsupported hugepage sizes (e.g., 64K hugepage with 4K pages) to be
treated as THP faults.

Tighten the check to filter out hugetlbfs pages. This also leads to
consistently mapping all unsupported hugepage sizes as PTE level
entries at stage 2.

Signed-off-by: Punit Agrawal <[email protected]>
Reviewed-by: Suzuki Poulose <[email protected]>
Cc: Christoffer Dall <[email protected]>
Cc: Marc Zyngier <[email protected]>
Cc: [email protected] # v4.13+
Signed-off-by: Marc Zyngier <[email protected]>
  • Loading branch information
punitagrawal authored and Marc Zyngier committed Oct 3, 2018
1 parent f072534 commit fd2ef35
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion virt/kvm/arm/mmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -1231,8 +1231,14 @@ static bool transparent_hugepage_adjust(kvm_pfn_t *pfnp, phys_addr_t *ipap)
{
kvm_pfn_t pfn = *pfnp;
gfn_t gfn = *ipap >> PAGE_SHIFT;
struct page *page = pfn_to_page(pfn);

if (PageTransCompoundMap(pfn_to_page(pfn))) {
/*
* PageTransCompoungMap() returns true for THP and
* hugetlbfs. Make sure the adjustment is done only for THP
* pages.
*/
if (!PageHuge(page) && PageTransCompoundMap(page)) {
unsigned long mask;
/*
* The address we faulted on is backed by a transparent huge
Expand Down

0 comments on commit fd2ef35

Please sign in to comment.