sign transaction support for WTF

tahowallet · Feb 29, 2024 · a05f250 · a05f250
1 parent 98ef67a
commit a05f250
Show file tree

Hide file tree

Showing 8 changed files with 19 additions and 3 deletions.
diff --git a/ui/components/Shared/SharedAddress.tsx b/ui/components/Shared/SharedAddress.tsx
@@ -8,6 +8,7 @@ import SharedTooltip from "./SharedTooltip"
 import { trimWithEllipsis } from "../../utils/textUtils"
 
 type SharedAddressProps = {
+  id?: string
   address: string
   name?: string | undefined
   elide: boolean
@@ -31,6 +32,7 @@ type SharedAddressProps = {
  * `nameResolverSystem` prop is ignored.
  */
 export default function SharedAddress({
+  id,
   name,
   address,
   elide,
@@ -48,6 +50,7 @@ export default function SharedAddress({
 
   return (
     <button
+      id={id}
       type="button"
       onClick={copyAddress}
       title={`Copy to clipboard:\n${address}`}

diff --git a/ui/components/Shared/SharedCurrentAccountInformation.tsx b/ui/components/Shared/SharedCurrentAccountInformation.tsx
@@ -5,6 +5,7 @@ import { useAreInternalSignersUnlocked } from "../../hooks/signing-hooks"
 import SharedAvatar from "./SharedAvatar"
 
 type Props = {
+  address: string
   shortenedAddress: string
   name: string | undefined
   avatarURL: string | undefined
@@ -13,6 +14,7 @@ type Props = {
 }
 
 export default function SharedCurrentAccountInformation({
+  address,
   shortenedAddress,
   name,
   avatarURL,
@@ -23,7 +25,7 @@ export default function SharedCurrentAccountInformation({
   const icon = areInternalSignersUnlocked ? "unlock" : "lock"
   return (
     <div className={classNames("account_info_wrap", { hover: showHoverStyle })}>
-      <span className="account_info_label ellipsis">
+      <span title={address} className="account_info_label ellipsis">
         {name ?? shortenedAddress}
       </span>
       <SharedAvatar

diff --git a/ui/components/Shared/__tests__/SharedCurrentAccountInformation.test.tsx b/ui/components/Shared/__tests__/SharedCurrentAccountInformation.test.tsx
@@ -4,6 +4,7 @@ import SharedCurrentAccountInformation from "../SharedCurrentAccountInformation"
 import { renderWithProviders } from "../../../tests/test-utils"
 
 const name = "Name"
+const address = "0x208e0000000000000000000000000000000090cd"
 const shortenedAddress = "0x208e…090cd"
 const keyringId = "lock"
 const lock = "lock"
@@ -14,6 +15,7 @@ describe("SharedCurrentAccountInformation", () => {
     const ui = renderWithProviders(
       <SharedCurrentAccountInformation
         name={name}
+        address=""
         shortenedAddress=""
         avatarURL={undefined}
       />,
@@ -26,6 +28,7 @@ describe("SharedCurrentAccountInformation", () => {
     const ui = renderWithProviders(
       <SharedCurrentAccountInformation
         name={undefined}
+        address={address}
         shortenedAddress={shortenedAddress}
         avatarURL={undefined}
       />,
@@ -38,6 +41,7 @@ describe("SharedCurrentAccountInformation", () => {
     const ui = renderWithProviders(
       <SharedCurrentAccountInformation
         name={name}
+        address=""
         shortenedAddress=""
         avatarURL={undefined}
         showLockStatus={false}
@@ -52,6 +56,7 @@ describe("SharedCurrentAccountInformation", () => {
     const ui = renderWithProviders(
       <SharedCurrentAccountInformation
         name={name}
+        address=""
         shortenedAddress=""
         avatarURL={undefined}
         showLockStatus
@@ -68,6 +73,7 @@ describe("SharedCurrentAccountInformation", () => {
     const ui = renderWithProviders(
       <SharedCurrentAccountInformation
         name={name}
+        address=""
         shortenedAddress=""
         avatarURL={undefined}
         showLockStatus

diff --git a/...natureDetails/TransactionSignatureDetails/TransactionSignatureSummary/TransferSummary.tsx b/...natureDetails/TransactionSignatureDetails/TransactionSignatureSummary/TransferSummary.tsx
@@ -51,7 +51,7 @@ export function TransferSummaryBase({
         <div className="container">
           <div className="label">{t("sendTo")}</div>
           <div className="send_to">
-            <SharedAddress address={recipientAddress} name={recipientName} />
+            <SharedAddress id="recipientAddress" address={recipientAddress} name={recipientName} />
           </div>
         </div>
         <div className="divider" />

diff --git a/ui/components/Signing/Signer/SignerBaseFrame.tsx b/ui/components/Signing/Signer/SignerBaseFrame.tsx
@@ -30,11 +30,12 @@ export default function SignerBaseFrame({
     <>
       <div className="signature-details">{children}</div>
       <footer>
-        <TransactionButton size="large" type="secondary" onClick={onReject}>
+        <TransactionButton id="reject" size="large" type="secondary" onClick={onReject}>
           {t("reject")}
         </TransactionButton>
 
         <TransactionButton
+          id="sign"
           type="primaryGreen"
           size="large"
           onClick={onConfirm}

diff --git a/ui/components/Signing/Signer/TransactionButton.tsx b/ui/components/Signing/Signer/TransactionButton.tsx
@@ -18,6 +18,7 @@ export type TransactionButtonProps = SharedButtonProps & {
 
 // TODO: Rename this to signing button
 export default function TransactionButton({
+  id,
   type,
   size,
   isDisabled,
@@ -93,6 +94,7 @@ export default function TransactionButton({
 
   const renderButton = () => (
     <SharedButton
+      id={id}
       type={type}
       size={size}
       onClick={onClick}

diff --git a/ui/components/Signing/SigningNetworkAccountInfoTopBar.tsx b/ui/components/Signing/SigningNetworkAccountInfoTopBar.tsx
@@ -26,6 +26,7 @@ export default function SigningNetworkAccountInfoTopBar({
       </div>
       <div className="row_part account">
         <SharedCurrentAccountInformation
+          address={accountTotal.address}
           shortenedAddress={shortenedAddress}
           name={name}
           avatarURL={avatarURL}

diff --git a/ui/components/TopMenu/TopMenuProfileButton.tsx b/ui/components/TopMenu/TopMenuProfileButton.tsx
@@ -65,6 +65,7 @@ export default function TopMenuProfileButton(props: {
       >
         {truncatedAddress !== undefined && (
           <SharedCurrentAccountInformation
+            address={address ?? ""}
             shortenedAddress={truncatedAddress}
             name={name}
             avatarURL={avatarURL}