Merge pull request reactjs#173 from JetRunner/master

Fix ESLint Warnings & Add .eslintignore
talco · Sep 18, 2017 · 4ca059d · 4ca059d
2 parents d8a1d47 + e430a2a
commit 4ca059d
Show file tree

Hide file tree

Showing 9 changed files with 27 additions and 21 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -1 +1,2 @@
 node_modules
+__testfixtures__
diff --git a/transforms/React-PropTypes-to-prop-types.js b/transforms/React-PropTypes-to-prop-types.js
@@ -195,7 +195,9 @@ module.exports = function(file, api, options) {
         // Add back any nested destructured children.
         if (nestedPropTypesChildren) {
           // TODO: This shouldn't just use a template string but the `ast-types` docs were too opaque for me to follow.
-          const propTypeChildren = nestedPropTypesChildren.value.properties.map(property => property.key.name).join(', ');
+          const propTypeChildren = nestedPropTypesChildren.value.properties.map(
+            property => property.key.name
+          ).join(', ');
           const destructureStatement = j.template.statement([`const { ${propTypeChildren} } = ${localPropTypesName};`]);
 
           j(path.parent.parent).insertBefore(destructureStatement);

diff --git a/transforms/ReactNative-View-propTypes.js b/transforms/ReactNative-View-propTypes.js
@@ -12,11 +12,11 @@
 
 const isReactNativeImport = path => (
   path.parent.node.source.value === 'react-native'
-)
+);
 
 const isReactNativeRequire = path => (
   path.node.arguments.some(argument => argument.value === 'react-native')
-)
+);
 
 const isRootViewReference = path => (
   path.node.name === 'View' &&
@@ -102,7 +102,7 @@ module.exports = function(file, api, options) {
       .length === 0;
 
     // Determine which kind of import/require() we should create based on file contents
-    let useHasteModules = false
+    let useHasteModules = false;
     if (fileUsesImports) {
       useHasteModules = root
         .find(j.ImportSpecifier)
@@ -118,15 +118,15 @@ module.exports = function(file, api, options) {
     // Create a require statement or an import, based on file convention
     let importOrRequireStatement;
     if (fileUsesImports) {
-        const identifier = j.identifier('ViewPropTypes');
-        const variable = useHasteModules === true
+      const identifier = j.identifier('ViewPropTypes');
+      const variable = useHasteModules === true
           ? j.importDefaultSpecifier(identifier)
           : j.importSpecifier(identifier);
-        const source = useHasteModules === true
+      const source = useHasteModules === true
           ? 'ViewPropTypes'
-          : 'react-native'
+          : 'react-native';
 
-        importOrRequireStatement = j.importDeclaration(
+      importOrRequireStatement = j.importDeclaration(
           [variable], j.literal(source)
         );
     } else {

diff --git a/transforms/__tests__/error-boundaries.js b/transforms/__tests__/error-boundaries.js
@@ -8,12 +8,12 @@
  *
  */
 
-"use strict";
+'use strict';
 
-const tests = ["class-component", "create-class-component"];
+const tests = ['class-component', 'create-class-component'];
 
-const defineTest = require("jscodeshift/dist/testUtils").defineTest;
+const defineTest = require('jscodeshift/dist/testUtils').defineTest;
 
 tests.forEach(test => {
-  defineTest(__dirname, "error-boundaries", null, `error-boundaries/${test}`);
+  defineTest(__dirname, 'error-boundaries', null, `error-boundaries/${test}`);
 });
diff --git a/transforms/__tests__/react-to-react-dom-test.js b/transforms/__tests__/react-to-react-dom-test.js
@@ -32,5 +32,5 @@ describe('react-to-react-dom', () => {
       null,
       `react-to-react-dom/${ test }`
     )
-  )
+  );
 });
diff --git a/transforms/create-element-to-jsx.js b/transforms/create-element-to-jsx.js
@@ -114,7 +114,7 @@ module.exports = function(file, api, options) {
       return {
         attributes: [],
         extraComments: expression.comments || [],
-      }
+      };
     } else {
       throw new Error(`Unexpected attribute of type "${expression.type}"`);
     }
@@ -141,7 +141,7 @@ module.exports = function(file, api, options) {
         comments: propertyComments
       } = jsxIdentifierFor(node.property);
       identifier = j.jsxMemberExpression(objectIdentifier, propertyIdentifier);
-      comments.push(...objectComments, ...propertyComments)
+      comments.push(...objectComments, ...propertyComments);
     } else {
       identifier = j.jsxIdentifier(node.name);
     }

diff --git a/transforms/error-boundaries.js b/transforms/error-boundaries.js
@@ -4,8 +4,8 @@ module.exports = function(file, api, options) {
   return j(file.source)
     .find(j.Identifier)
     .forEach(path => {
-      if (path.node.name === "unstable_handleError") {
-        j(path).replaceWith(j.identifier("componentDidCatch"));
+      if (path.node.name === 'unstable_handleError') {
+        j(path).replaceWith(j.identifier('componentDidCatch'));
       }
     })
     .toSource();

diff --git a/transforms/react-to-react-dom.js b/transforms/react-to-react-dom.js
@@ -158,7 +158,6 @@ module.exports = function(file, api) {
         }
         coreImportDeclaration = p;
         var defaultSpecifier = p.value.specifiers.find(sp => sp.type === j.ImportDefaultSpecifier.name);
-        var specifiers = p.value.specifiers.filter(sp => sp.type === j.ImportSpecifier.name);
         if (defaultSpecifier) {
           var name = defaultSpecifier.local.name;
           var scope = p.scope.lookup(name);
@@ -352,7 +351,9 @@ module.exports = function(file, api) {
       }
 
       function emitImport(name, path, knownProperties, uses) {
-        const usedProperties = coreImportDeclaration.value.specifiers.filter(sp => sp.type === j.ImportSpecifier.name).filter(sp =>
+        const usedProperties = coreImportDeclaration.value.specifiers.filter(
+          sp => sp.type === j.ImportSpecifier.name
+        ).filter(sp =>
           sp.imported.type === 'Identifier' && knownProperties.indexOf(sp.imported.name) !== -1
         ).map(sp => sp.imported.name);
 

diff --git a/transforms/sort-comp.js b/transforms/sort-comp.js
@@ -13,7 +13,9 @@
 /**
  * Reorders React component methods to match the [ESLint](http://eslint.org/)
  * [react/sort-comp rule](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/sort-comp.md),
- * specifically with the [tighter constraints of the Airbnb style guide](https://github.com/airbnb/javascript/blob/7684892951ef663e1c4e62ad57d662e9b2748b9e/packages/eslint-config-airbnb/rules/react.js#L122-L134),
+ * specifically with the [tighter constraints of the Airbnb style guide]
+ * (https://github.com/airbnb/javascript/blob/7684892951ef663e1c4e62ad57d662e9b2748b9e/\
+ * packages/eslint-config-airbnb/rules/react.js#L122-L134),
  *
  *  'react/sort-comp': [2, {
  *    'order': [
-Original file line number
+Diff line change
@@ Expand Up / @@ -32,5 +32,5 @@ describe('react-to-react-dom', () => { @@
           null,
           `react-to-react-dom/${ test }`
         )
-      )
+      );
     });