Skip to content

Commit

Permalink
Fixed logging.
Browse files Browse the repository at this point in the history
  • Loading branch information
pluknet committed Mar 30, 2016
1 parent 53fec2c commit 00ef9ff
Show file tree
Hide file tree
Showing 39 changed files with 67 additions and 66 deletions.
2 changes: 1 addition & 1 deletion src/core/nginx.c
Original file line number Diff line number Diff line change
Expand Up @@ -1510,7 +1510,7 @@ ngx_load_module(ngx_conf_t *cf, ngx_command_t *cmd, void *conf)
return NGX_CONF_ERROR;
}

ngx_log_debug2(NGX_LOG_DEBUG_CORE, cf->log, 0, "module: %s i:%i",
ngx_log_debug2(NGX_LOG_DEBUG_CORE, cf->log, 0, "module: %s i:%ui",
module->name, module->index);
}

Expand Down
6 changes: 3 additions & 3 deletions src/core/ngx_cycle.c
Original file line number Diff line number Diff line change
Expand Up @@ -1313,7 +1313,7 @@ ngx_clean_old_cycles(ngx_event_t *ev)
if (cycle[i]->connections[n].fd != (ngx_socket_t) -1) {
found = 1;

ngx_log_debug1(NGX_LOG_DEBUG_CORE, log, 0, "live fd:%d", n);
ngx_log_debug1(NGX_LOG_DEBUG_CORE, log, 0, "live fd:%ui", n);

break;
}
Expand All @@ -1324,13 +1324,13 @@ ngx_clean_old_cycles(ngx_event_t *ev)
continue;
}

ngx_log_debug1(NGX_LOG_DEBUG_CORE, log, 0, "clean old cycle: %d", i);
ngx_log_debug1(NGX_LOG_DEBUG_CORE, log, 0, "clean old cycle: %ui", i);

ngx_destroy_pool(cycle[i]->pool);
cycle[i] = NULL;
}

ngx_log_debug1(NGX_LOG_DEBUG_CORE, log, 0, "old cycles status: %d", live);
ngx_log_debug1(NGX_LOG_DEBUG_CORE, log, 0, "old cycles status: %ui", live);

if (live) {
ngx_add_timer(ev, 30000);
Expand Down
4 changes: 2 additions & 2 deletions src/core/ngx_file.c
Original file line number Diff line number Diff line change
Expand Up @@ -841,7 +841,7 @@ ngx_copy_file(u_char *from, u_char *to, ngx_copy_file_t *cf)

if ((size_t) n != len) {
ngx_log_error(NGX_LOG_ALERT, cf->log, 0,
ngx_read_fd_n " has read only %z of %uz from %s",
ngx_read_fd_n " has read only %z of %O from %s",
n, size, from);
goto failed;
}
Expand All @@ -856,7 +856,7 @@ ngx_copy_file(u_char *from, u_char *to, ngx_copy_file_t *cf)

if ((size_t) n != len) {
ngx_log_error(NGX_LOG_ALERT, cf->log, 0,
ngx_write_fd_n " has written only %z of %uz to %s",
ngx_write_fd_n " has written only %z of %O to %s",
n, size, to);
goto failed;
}
Expand Down
3 changes: 2 additions & 1 deletion src/core/ngx_slab.c
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,8 @@ ngx_slab_alloc_locked(ngx_slab_pool_t *pool, size_t size)

done:

ngx_log_debug1(NGX_LOG_DEBUG_ALLOC, ngx_cycle->log, 0, "slab alloc: %p", p);
ngx_log_debug1(NGX_LOG_DEBUG_ALLOC, ngx_cycle->log, 0,
"slab alloc: %p", (void *) p);

return (void *) p;
}
Expand Down
2 changes: 1 addition & 1 deletion src/event/modules/ngx_epoll_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -902,7 +902,7 @@ ngx_epoll_eventfd_handler(ngx_event_t *ev)
events = io_getevents(ngx_aio_ctx, 1, 64, event, &ts);

ngx_log_debug1(NGX_LOG_DEBUG_EVENT, ev->log, 0,
"io_getevents: %l", events);
"io_getevents: %d", events);

if (events > 0) {
ready -= events;
Expand Down
2 changes: 1 addition & 1 deletion src/event/ngx_event.c
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ ngx_event_module_init(ngx_cycle_t *cycle)
(void) ngx_atomic_cmp_set(ngx_connection_counter, 0, 1);

ngx_log_debug2(NGX_LOG_DEBUG_EVENT, cycle->log, 0,
"counter: %p, %d",
"counter: %p, %uA",
ngx_connection_counter, *ngx_connection_counter);

ngx_temp_number = (ngx_atomic_t *) (shared + 2 * cl);
Expand Down
4 changes: 2 additions & 2 deletions src/event/ngx_event_openssl.c
Original file line number Diff line number Diff line change
Expand Up @@ -1596,7 +1596,7 @@ ngx_ssl_send_chain(ngx_connection_t *c, ngx_chain_t *in, off_t limit)
}

ngx_log_debug1(NGX_LOG_DEBUG_EVENT, c->log, 0,
"SSL buf copy: %d", size);
"SSL buf copy: %z", size);

ngx_memcpy(buf->last, in->buf->pos, size);

Expand Down Expand Up @@ -1668,7 +1668,7 @@ ngx_ssl_write(ngx_connection_t *c, u_char *data, size_t size)

ngx_ssl_clear_error(c->log);

ngx_log_debug1(NGX_LOG_DEBUG_EVENT, c->log, 0, "SSL to write: %d", size);
ngx_log_debug1(NGX_LOG_DEBUG_EVENT, c->log, 0, "SSL to write: %uz", size);

n = SSL_write(c->ssl->connection, data, size);

Expand Down
2 changes: 1 addition & 1 deletion src/event/ngx_event_openssl_stapling.c
Original file line number Diff line number Diff line change
Expand Up @@ -1219,7 +1219,7 @@ ngx_ssl_ocsp_create_request(ngx_ssl_ocsp_ctx_t *ctx)

ngx_log_debug2(NGX_LOG_DEBUG_EVENT, ctx->log, 0,
"ssl ocsp request length %z, escape %d",
base64.len, escape);
base64.len, (int) escape);

len = sizeof("GET ") - 1 + ctx->uri.len + sizeof("/") - 1
+ base64.len + 2 * escape + sizeof(" HTTP/1.0" CRLF) - 1
Expand Down
2 changes: 1 addition & 1 deletion src/event/ngx_event_pipe.c
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,7 @@ ngx_event_pipe_write_to_downstream(ngx_event_pipe_t *p)
flush:

ngx_log_debug2(NGX_LOG_DEBUG_EVENT, p->log, 0,
"pipe write: out:%p, f:%d", out, flush);
"pipe write: out:%p, f:%ui", out, flush);

if (out == NULL) {

Expand Down
2 changes: 1 addition & 1 deletion src/http/modules/ngx_http_auth_basic_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ ngx_http_auth_basic_crypt_handler(ngx_http_request_t *r,
&encrypted);

ngx_log_debug3(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"rc: %d user: \"%V\" salt: \"%s\"",
"rc: %i user: \"%V\" salt: \"%s\"",
rc, &r->headers_in.user, passwd->data);

if (rc == NGX_OK) {
Expand Down
4 changes: 2 additions & 2 deletions src/http/modules/ngx_http_auth_request_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ ngx_http_auth_request_handler(ngx_http_request_t *r)
}

ngx_log_error(NGX_LOG_ERR, r->connection->log, 0,
"auth request unexpected status: %d", ctx->status);
"auth request unexpected status: %ui", ctx->status);

return NGX_HTTP_INTERNAL_SERVER_ERROR;
}
Expand Down Expand Up @@ -219,7 +219,7 @@ ngx_http_auth_request_done(ngx_http_request_t *r, void *data, ngx_int_t rc)
ngx_http_auth_request_ctx_t *ctx = data;

ngx_log_debug1(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"auth request done s:%d", r->headers_out.status);
"auth request done s:%ui", r->headers_out.status);

ctx->done = 1;
ctx->status = r->headers_out.status;
Expand Down
2 changes: 1 addition & 1 deletion src/http/modules/ngx_http_chunked_filter_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ ngx_http_chunked_body_filter(ngx_http_request_t *r, ngx_chain_t *in)

for ( ;; ) {
ngx_log_debug1(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"http chunk: %d", ngx_buf_size(cl->buf));
"http chunk: %O", ngx_buf_size(cl->buf));

size += ngx_buf_size(cl->buf);

Expand Down
6 changes: 3 additions & 3 deletions src/http/modules/ngx_http_fastcgi_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -1653,7 +1653,7 @@ ngx_http_fastcgi_process_header(ngx_http_request_t *r)
&& f->type != NGX_HTTP_FASTCGI_STDERR)
{
ngx_log_error(NGX_LOG_ERR, r->connection->log, 0,
"upstream sent unexpected FastCGI record: %d",
"upstream sent unexpected FastCGI record: %ui",
f->type);

return NGX_HTTP_UPSTREAM_INVALID_HEADER;
Expand Down Expand Up @@ -1834,7 +1834,7 @@ ngx_http_fastcgi_process_header(ngx_http_request_t *r)
rc = ngx_http_parse_header_line(r, &u->buffer, 1);

ngx_log_debug1(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"http fastcgi parser: %d", rc);
"http fastcgi parser: %i", rc);

if (rc == NGX_AGAIN) {
break;
Expand Down Expand Up @@ -2505,7 +2505,7 @@ ngx_http_fastcgi_non_buffered_filter(void *data, ssize_t bytes)

for (cl = u->out_bufs; cl; cl = cl->next) {
ngx_log_debug3(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"http fastcgi in memory %p-%p %uz",
"http fastcgi in memory %p-%p %O",
cl->buf->pos, cl->buf->last, ngx_buf_size(cl->buf));

if (buf->last == cl->buf->pos) {
Expand Down
4 changes: 2 additions & 2 deletions src/http/modules/ngx_http_gzip_filter_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -1009,14 +1009,14 @@ ngx_http_gzip_filter_alloc(void *opaque, u_int items, u_int size)
ctx->allocated -= alloc;

ngx_log_debug4(NGX_LOG_DEBUG_HTTP, ctx->request->connection->log, 0,
"gzip alloc: n:%ud s:%ud a:%ud p:%p",
"gzip alloc: n:%ud s:%ud a:%ui p:%p",
items, size, alloc, p);

return p;
}

ngx_log_error(NGX_LOG_ALERT, ctx->request->connection->log, 0,
"gzip filter failed to use preallocated memory: %ud of %ud",
"gzip filter failed to use preallocated memory: %ud of %ui",
items * size, ctx->allocated);

p = ngx_palloc(ctx->request->pool, items * size);
Expand Down
2 changes: 1 addition & 1 deletion src/http/modules/ngx_http_image_filter_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,7 @@ ngx_http_image_size(ngx_http_request_t *r, ngx_http_image_filter_ctx_t *ctx)
}

ngx_log_debug2(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"image size: %d x %d", width, height);
"image size: %d x %d", (int) width, (int) height);

ctx->width = width;
ctx->height = height;
Expand Down
4 changes: 2 additions & 2 deletions src/http/modules/ngx_http_limit_conn_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ ngx_http_limit_conn_handler(ngx_http_request_t *r)
}

ngx_log_debug2(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"limit conn: %08XD %d", node->key, lc->conn);
"limit conn: %08Xi %d", node->key, lc->conn);

ngx_shmtx_unlock(&shpool->mutex);

Expand Down Expand Up @@ -351,7 +351,7 @@ ngx_http_limit_conn_cleanup(void *data)
ngx_shmtx_lock(&shpool->mutex);

ngx_log_debug2(NGX_LOG_DEBUG_HTTP, lccln->shm_zone->shm.log, 0,
"limit conn cleanup: %08XD %d", node->key, lc->conn);
"limit conn cleanup: %08Xi %d", node->key, lc->conn);

lc->conn--;

Expand Down
2 changes: 1 addition & 1 deletion src/http/modules/ngx_http_map_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ ngx_http_map_variable(ngx_http_request_t *r, ngx_http_variable_value_t *v,
*v = *value;

ngx_log_debug2(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"http map: \"%v\" \"%v\"", &val, v);
"http map: \"%V\" \"%v\"", &val, v);

return NGX_OK;
}
Expand Down
2 changes: 1 addition & 1 deletion src/http/modules/ngx_http_memcached_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ ngx_http_memcached_filter(void *data, ssize_t bytes)
cl->buf->tag = u->output.tag;

ngx_log_debug4(NGX_LOG_DEBUG_HTTP, ctx->request->connection->log, 0,
"memcached filter bytes:%z size:%z length:%z rest:%z",
"memcached filter bytes:%z size:%z length:%O rest:%z",
bytes, b->last - b->pos, u->length, ctx->rest);

if (bytes <= (ssize_t) (u->length - NGX_HTTP_MEMCACHED_END)) {
Expand Down
8 changes: 4 additions & 4 deletions src/http/modules/ngx_http_proxy_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -1559,7 +1559,7 @@ ngx_http_proxy_body_output_filter(void *data, ngx_chain_t *in)

for ( ;; ) {
ngx_log_debug1(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"proxy output chunk: %d", ngx_buf_size(cl->buf));
"proxy output chunk: %O", ngx_buf_size(cl->buf));

size += ngx_buf_size(cl->buf);

Expand Down Expand Up @@ -1917,7 +1917,7 @@ ngx_http_proxy_input_filter_init(void *data)
}

ngx_log_debug4(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"http proxy filter init s:%d h:%d c:%d l:%O",
"http proxy filter init s:%ui h:%d c:%d l:%O",
u->headers_in.status_n, ctx->head, u->headers_in.chunked,
u->headers_in.content_length_n);

Expand Down Expand Up @@ -2125,7 +2125,7 @@ ngx_http_proxy_chunked_filter(ngx_event_pipe_t *p, ngx_buf_t *buf)
}

ngx_log_debug2(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"http proxy chunked state %d, length %d",
"http proxy chunked state %ui, length %O",
ctx->chunked.state, p->length);

if (b) {
Expand Down Expand Up @@ -2299,7 +2299,7 @@ ngx_http_proxy_non_buffered_chunked_filter(void *data, ssize_t bytes)

for (cl = u->out_bufs; cl; cl = cl->next) {
ngx_log_debug3(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"http proxy in memory %p-%p %uz",
"http proxy in memory %p-%p %O",
cl->buf->pos, cl->buf->last, ngx_buf_size(cl->buf));

if (buf->last == cl->buf->pos) {
Expand Down
2 changes: 1 addition & 1 deletion src/http/modules/ngx_http_range_filter_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ ngx_http_range_header_filter(ngx_http_request_t *r)
if_range_time = ngx_parse_http_time(if_range->data, if_range->len);

ngx_log_debug2(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"http ir:%d lm:%d",
"http ir:%T lm:%T",
if_range_time, r->headers_out.last_modified_time);

if (if_range_time != r->headers_out.last_modified_time) {
Expand Down
8 changes: 4 additions & 4 deletions src/http/modules/ngx_http_ssi_filter_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -468,12 +468,12 @@ ngx_http_ssi_body_filter(ngx_http_request_t *r, ngx_chain_t *in)
while (ctx->pos < ctx->buf->last) {

ngx_log_debug2(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"saved: %d state: %d", ctx->saved, ctx->state);
"saved: %uz state: %ui", ctx->saved, ctx->state);

rc = ngx_http_ssi_parse(r, ctx);

ngx_log_debug4(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"parse: %d, looked: %d %p-%p",
"parse: %i, looked: %uz %p-%p",
rc, ctx->looked, ctx->copy_start, ctx->copy_end);

if (rc == NGX_ERROR) {
Expand All @@ -485,7 +485,7 @@ ngx_http_ssi_body_filter(ngx_http_request_t *r, ngx_chain_t *in)
if (ctx->output) {

ngx_log_debug1(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"saved: %d", ctx->saved);
"saved: %uz", ctx->saved);

if (ctx->saved) {

Expand Down Expand Up @@ -1911,7 +1911,7 @@ ngx_http_ssi_regex_match(ngx_http_request_t *r, ngx_str_t *pattern,

if (rc < NGX_REGEX_NO_MATCHED) {
ngx_log_error(NGX_LOG_ALERT, r->connection->log, 0,
ngx_regex_exec_n " failed: %i on \"%V\" using \"%V\"",
ngx_regex_exec_n " failed: %d on \"%V\" using \"%V\"",
rc, str, pattern);
return NGX_HTTP_SSI_ERROR;
}
Expand Down
2 changes: 1 addition & 1 deletion src/http/modules/ngx_http_sub_filter_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ ngx_http_sub_body_filter(ngx_http_request_t *r, ngx_chain_t *in)
rc = ngx_http_sub_parse(r, ctx);

ngx_log_debug4(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"parse: %d, looked: \"%V\" %p-%p",
"parse: %i, looked: \"%V\" %p-%p",
rc, &ctx->looked, ctx->copy_start, ctx->copy_end);

if (rc == NGX_ERROR) {
Expand Down
2 changes: 1 addition & 1 deletion src/http/modules/ngx_http_upstream_ip_hash_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ ngx_http_upstream_get_ip_hash_peer(ngx_peer_connection_t *pc, void *data)
}

ngx_log_debug2(NGX_LOG_DEBUG_HTTP, pc->log, 0,
"get ip hash peer, hash: %ui %04XA", p, m);
"get ip hash peer, hash: %ui %04XL", p, (uint64_t) m);

if (peer->down) {
goto next;
Expand Down
12 changes: 6 additions & 6 deletions src/http/ngx_http_request.c
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ ngx_http_ssl_handshake(ngx_event_t *rev)

err = ngx_socket_errno;

ngx_log_debug1(NGX_LOG_DEBUG_HTTP, rev->log, 0, "http recv(): %d", n);
ngx_log_debug1(NGX_LOG_DEBUG_HTTP, rev->log, 0, "http recv(): %z", n);

if (n == -1) {
if (err == NGX_EAGAIN) {
Expand Down Expand Up @@ -1500,7 +1500,7 @@ ngx_http_alloc_large_header_buffer(ngx_http_request_t *r,
}

ngx_log_debug1(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"http large header copy: %d", r->header_in->pos - old);
"http large header copy: %uz", r->header_in->pos - old);

new = b->start;

Expand Down Expand Up @@ -2264,7 +2264,7 @@ ngx_http_finalize_request(ngx_http_request_t *r, ngx_int_t rc)
c = r->connection;

ngx_log_debug5(NGX_LOG_DEBUG_HTTP, c->log, 0,
"http finalize request: %d, \"%V?%V\" a:%d, c:%d",
"http finalize request: %i, \"%V?%V\" a:%d, c:%d",
rc, &r->uri, &r->args, r == c->data, r->main->count);

if (rc == NGX_DONE) {
Expand Down Expand Up @@ -2956,7 +2956,7 @@ ngx_http_set_keepalive(ngx_http_request_t *r)
b->last = b->start;
}

ngx_log_debug2(NGX_LOG_DEBUG_HTTP, c->log, 0, "hc free: %p %d",
ngx_log_debug2(NGX_LOG_DEBUG_HTTP, c->log, 0, "hc free: %p %i",
hc->free, hc->nfree);

if (hc->free) {
Expand All @@ -2968,7 +2968,7 @@ ngx_http_set_keepalive(ngx_http_request_t *r)
hc->nfree = 0;
}

ngx_log_debug2(NGX_LOG_DEBUG_HTTP, c->log, 0, "hc busy: %p %d",
ngx_log_debug2(NGX_LOG_DEBUG_HTTP, c->log, 0, "hc busy: %p %i",
hc->busy, hc->nbusy);

if (hc->busy) {
Expand Down Expand Up @@ -3259,7 +3259,7 @@ ngx_http_lingering_close_handler(ngx_event_t *rev)
do {
n = c->recv(c, buffer, NGX_HTTP_LINGERING_BUFFER_SIZE);

ngx_log_debug1(NGX_LOG_DEBUG_HTTP, c->log, 0, "lingering read: %d", n);
ngx_log_debug1(NGX_LOG_DEBUG_HTTP, c->log, 0, "lingering read: %z", n);

if (n == NGX_ERROR || n == 0) {
ngx_http_close_request(r, 0);
Expand Down
2 changes: 1 addition & 1 deletion src/http/ngx_http_script.c
Original file line number Diff line number Diff line change
Expand Up @@ -1488,7 +1488,7 @@ ngx_http_script_file_code(ngx_http_script_engine_t *e)
r = e->request;

ngx_log_debug2(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
"http script file op %p \"%V\"", code->op, &path);
"http script file op %p \"%V\"", (void *) code->op, &path);

clcf = ngx_http_get_module_loc_conf(r, ngx_http_core_module);

Expand Down
Loading

0 comments on commit 00ef9ff

Please sign in to comment.