Test Switch Profile for IstioControlPlane via controller (istio#380)

* Test Switch Profile for IstioControlPlane via controller * Fix Lint error * Fix Lint error * Fix Lint error * Fix Lint error * Fix Lint error * Fix Lint error
tangiel · Oct 15, 2019 · a178b46 · a178b46
1 parent b0fbbf2
commit a178b46
Showing 1 changed file with 196 additions and 0 deletions.
diff --git a/pkg/controller/istiocontrolplane/istiocontrolplane_controller_test.go b/pkg/controller/istiocontrolplane/istiocontrolplane_controller_test.go
@@ -0,0 +1,196 @@
+// Copyright 2019 Istio Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package istiocontrolplane
+
+import (
+	"context"
+	"fmt"
+	"testing"
+
+	"istio.io/operator/pkg/apis/istio/v1alpha2"
+
+	"istio.io/operator/pkg/helmreconciler"
+
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/runtime"
+	"k8s.io/apimachinery/pkg/types"
+	"k8s.io/client-go/kubernetes/scheme"
+	"sigs.k8s.io/controller-runtime/pkg/client"
+	"sigs.k8s.io/controller-runtime/pkg/client/fake"
+	"sigs.k8s.io/controller-runtime/pkg/reconcile"
+)
+
+// TestICPController runs ReconcileIstioControlPlane.Reconcile() against a
+// fake client that tracks an IstioControlPlane object.
+func TestICPController_SwitchProfile(t *testing.T) {
+	name := "example-istiocontrolplane"
+	namespace := "istio-system"
+	icp := &v1alpha2.IstioControlPlane{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      name,
+			Namespace: namespace,
+		},
+		Spec: &v1alpha2.IstioControlPlaneSpec{
+			Profile: "minimal",
+		},
+	}
+	objs := []runtime.Object{
+		icp,
+	}
+
+	s := scheme.Scheme
+	s.AddKnownTypes(v1alpha2.SchemeGroupVersion, icp)
+	cl := fake.NewFakeClientWithScheme(s, objs...)
+	factory := &helmreconciler.Factory{CustomizerFactory: &IstioRenderingCustomizerFactory{}}
+	r := &ReconcileIstioControlPlane{client: cl, scheme: s, factory: factory}
+
+	req := reconcile.Request{
+		NamespacedName: types.NamespacedName{
+			Name:      name,
+			Namespace: namespace,
+		},
+	}
+	res, err := r.Reconcile(req)
+	if err != nil {
+		t.Fatalf("reconcile: (%v)", err)
+	}
+	// check ICP status
+	succeed, err := checkICPStatus(cl, req.NamespacedName, "minimal")
+	if !succeed || err != nil {
+		t.Fatalf("failed to get expected IstioControlPlane status: (%v)", err)
+	}
+
+	//update IstioControlPlane : switch profile from minimal to default and reconcile
+	err = switchIstioControlPlaneProfile(cl, req.NamespacedName, "default")
+	if err != nil {
+		t.Fatalf("failed to update IstioControlPlane: (%v)", err)
+	}
+	res, err = r.Reconcile(req)
+	if err != nil {
+		t.Fatalf("reconcile: (%v)", err)
+	}
+	if res.Requeue {
+		t.Error("reconcile requeue which is not expected")
+	}
+	// check ICP status
+	succeed, err = checkICPStatus(cl, req.NamespacedName, "default")
+	if !succeed || err != nil {
+		t.Fatalf("failed to get expected IstioControlPlane status: (%v)", err)
+	}
+
+	//update IstioControlPlane : switch profile from default to minimal again and reconcile
+	err = switchIstioControlPlaneProfile(cl, req.NamespacedName, "minimal")
+	if err != nil {
+		t.Fatalf("failed to update IstioControlPlane: (%v)", err)
+	}
+	res, err = r.Reconcile(req)
+	if err != nil {
+		t.Fatalf("reconcile: (%v)", err)
+	}
+	// Check the result of reconciliation to make sure it has the desired state.
+	if res.Requeue {
+		t.Error("reconcile requeue which is not expected")
+	}
+	// check ICP status
+	succeed, err = checkICPStatus(cl, req.NamespacedName, "minimal")
+	if !succeed || err != nil {
+		t.Fatalf("failed to get expected IstioControlPlane status: (%v)", err)
+	}
+
+}
+func statusExpected(s1, s2 *v1alpha2.InstallStatus_VersionStatus) bool {
+	return s1.Status.String() == s2.Status.String()
+}
+
+func switchIstioControlPlaneProfile(cl client.Client, key client.ObjectKey, profile string) error {
+	instance := &v1alpha2.IstioControlPlane{}
+	err := cl.Get(context.TODO(), key, instance)
+	if err != nil {
+		return err
+	}
+	instance.Spec.Profile = profile
+	err = cl.Update(context.TODO(), instance)
+	if err != nil {
+		return err
+	}
+	return nil
+}
+func checkICPStatus(cl client.Client, key client.ObjectKey, profile string) (bool, error) {
+	minimalStatus := map[string]*v1alpha2.InstallStatus_VersionStatus{
+		"Pilot": {
+			Status: v1alpha2.InstallStatus_HEALTHY,
+		},
+		"crds": {
+			Status: v1alpha2.InstallStatus_HEALTHY,
+		},
+	}
+	defaultStatus := map[string]*v1alpha2.InstallStatus_VersionStatus{
+		"crds": {
+			Status: v1alpha2.InstallStatus_HEALTHY,
+		},
+		"Pilot": {
+			Status: v1alpha2.InstallStatus_HEALTHY,
+		},
+		"Policy": {
+			Status: v1alpha2.InstallStatus_HEALTHY,
+		},
+		"Telemetry": {
+			Status: v1alpha2.InstallStatus_HEALTHY,
+		},
+		"Injector": {
+			Status: v1alpha2.InstallStatus_HEALTHY,
+		},
+		"Citadel": {
+			Status: v1alpha2.InstallStatus_HEALTHY,
+		},
+		"Galley": {
+			Status: v1alpha2.InstallStatus_HEALTHY,
+		},
+		"Prometheus": {
+			Status: v1alpha2.InstallStatus_HEALTHY,
+		},
+		"IngressGateway": {
+			Status: v1alpha2.InstallStatus_HEALTHY,
+		},
+	}
+	instance := &v1alpha2.IstioControlPlane{}
+	err := cl.Get(context.TODO(), key, instance)
+	if err != nil {
+		return false, err
+	}
+	var status map[string]*v1alpha2.InstallStatus_VersionStatus
+	switch profile {
+	case "minimal":
+		status = minimalStatus
+	case "default":
+		status = defaultStatus
+	}
+	installStatus := instance.GetStatus()
+	size := len(installStatus.Status)
+	expectedSize := len(status)
+	if size != expectedSize {
+		return false, fmt.Errorf("status size(%v) is not equal to expected status size (%v)", size, expectedSize)
+	}
+	for k, v := range installStatus.Status {
+		if s, ok := status[k]; ok {
+			if !statusExpected(s, v) {
+				return false, fmt.Errorf("failed to get Expected IstioControlPlane status: (%s)", k)
+			}
+		} else {
+			return false, fmt.Errorf("failed to find Expected IstioControlPlane status: (%s)", k)
+		}
+	}
+	return true, nil
+}