Write generated Java files to disk only if debug flag is set

Fixes elastic#11082
tanglisha · Aug 28, 2019 · 398e64e · 398e64e
1 parent b66329f
commit 398e64e
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/logstash-core/src/main/java/org/logstash/config/ir/compiler/ComputeStepSyntaxElement.java b/logstash-core/src/main/java/org/logstash/config/ir/compiler/ComputeStepSyntaxElement.java
@@ -74,9 +74,13 @@ public T instantiate() {
                 } else {
                     final String name = String.format("CompiledDataset%d", CLASS_CACHE.size());
                     final String code = generateCode(name);
-                    final Path sourceFile = SOURCE_DIR.resolve(String.format("%s.java", name));
-                    Files.write(sourceFile, code.getBytes(StandardCharsets.UTF_8));
-                    COMPILER.cookFile(sourceFile.toFile());
+                    if (SOURCE_DIR != null) {
+                        final Path sourceFile = SOURCE_DIR.resolve(String.format("%s.java", name));
+                        Files.write(sourceFile, code.getBytes(StandardCharsets.UTF_8));
+                        COMPILER.cookFile(sourceFile.toFile());
+                    } else {
+                        COMPILER.cook(code);
+                    }
                     COMPILER.setParentClassLoader(COMPILER.getClassLoader());
                     clazz = (Class<T>) COMPILER.getClassLoader().loadClass(
                         String.format("org.logstash.generated.%s", name)
@@ -125,17 +129,15 @@ private String generateCode(final String name) {
     }
 
     private static Path debugDir() {
-        final Path sourceDir;
+        Path sourceDir = null;
         try {
             final Path parentDir;
             final String dir = System.getProperty(ICookable.SYSTEM_PROPERTY_SOURCE_DEBUGGING_DIR);
-            if (dir == null) {
-                parentDir = Files.createTempDirectory("logstash");
-            } else {
+            if (dir != null) {
                 parentDir = Paths.get(dir);
+                sourceDir = parentDir.resolve("org").resolve("logstash").resolve("generated");
+                Files.createDirectories(sourceDir);
             }
-            sourceDir = parentDir.resolve("org").resolve("logstash").resolve("generated");
-            Files.createDirectories(sourceDir);
         } catch (final IOException ex) {
             throw new IllegalStateException(ex);
         }