Support File params in ajax_lite #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever the request params in a non-GET ajax-lite contain an instance of File, convert the request body into a FormData object rather than encoding it to a query string, and use that to send to the XHR
glittershark
force-pushed
the
file-params
branch
from
1a0b3c4 to
4461325
Compare
ptaoussanis
pushed a commit
that referenced
this pull request
Jul 17, 2016
Whenever the request params in a non-GET ajax-lite contain an instance of File, convert the request body into a FormData object rather than encoding it to a query string, and use that to send to the XHR
ptaoussanis
added a commit
that referenced
this pull request
Jul 17, 2016
|
Thanks Griffin, have merged. Util was due for a refactor, so took a quick run at 3e18d16. Would appreciate a second pair of eyes on that. Thanks! |
ptaoussanis
added a commit
that referenced
this pull request
Jul 17, 2016
ptaoussanis
added a commit
that referenced
this pull request
Jul 18, 2016
|
Took a look at 3e18d16 - nothing major there I would change. thanks for the quick merge! |
|
Great, thank you. And appreciate the support! Cheers :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the request params in a non-GET ajax-lite contain an instance
of File, convert the request body into a FormData object rather than
encoding it to a query string, and use that to send to the XHR