Remove reflection warning caused by overloads introduced by Java 10 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java 10 added an overload with a Charset as second argument for these methods: java.net.URLEncoder.encode(java.lang.String, java.lang.String) java.net.URLEncoder.encode(java.lang.String, java.nio.charset.Charset) java.net.URLDecoder.decode(java.lang.String, java.lang.String) java.net.URLDecoder.decode(java.lang.String, java.nio.charset.Charset) My change removes the reflection warning by casting both arguments to String in the #+clj case trusting that clojure prefers the String variant. Please note the asymmetry in the implementation of url-encode which calls str on the first argument and url-decode which does not.
|
Thanks Ulrich, merging manually! |
ptaoussanis
pushed a commit
that referenced
this pull request
Aug 10, 2018
…a 10 (@kassapo) Java 10 added an overload with a Charset as second argument for these methods: java.net.URLEncoder.encode(java.lang.String, java.lang.String) java.net.URLEncoder.encode(java.lang.String, java.nio.charset.Charset) java.net.URLDecoder.decode(java.lang.String, java.lang.String) java.net.URLDecoder.decode(java.lang.String, java.nio.charset.Charset) My change removes the reflection warning by casting both arguments to String in the #+clj case trusting that clojure prefers the String variant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 10 added an overload with a Charset as second argument for these
methods:
java.net.URLEncoder.encode(java.lang.String, java.lang.String)
java.net.URLEncoder.encode(java.lang.String, java.nio.charset.Charset)
java.net.URLDecoder.decode(java.lang.String, java.lang.String)
java.net.URLDecoder.decode(java.lang.String, java.nio.charset.Charset)
My change removes the reflection warning by casting both arguments to
String in the #+clj case trusting that clojure prefers the String
variant.
Please note the asymmetry in the implementation of url-encode which
calls str on the first argument and url-decode which does not.