enh: connector implements autocommit #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| c.nextAutoCommitTime = time.Now().Add(c.autoCommitInterval) | ||
| } else { | ||
| if time.Now().After(c.nextAutoCommitTime) { | ||
| c.doCommit() |
There was a problem hiding this comment.
这样不兼容以前Adapter接口了，就是go的连接器没法调用老版本的Adapter
There was a problem hiding this comment.
each go connector release has a minimum tdengine version requirement
| offset, err = consumer.Committed(partitions, 0) | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, 1, len(offset)) | ||
| assert.GreaterOrEqual(t, offset[0].Offset, messageOffset) |
There was a problem hiding this comment.
测试用例只有一条数据，第一次拉取成功后，后面其实无法验证是否自动提交触发。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.