Alternative TAP command support #20
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added to this PR a way for |
|
I don't think there's any value in supporting the word "assertions" when tape and TAP itself both don't. If that can be removed, and there's still value in the rest of the PR, I'd love to see it rebased so it can be landed. |
This comment was marked as resolved.
This comment was marked as resolved.
|
I posted this 6 years ago and no longer even remember what this is about. If you're dependent on me to do anything with this, then you might as well close it. I'll be unsubscribing from it. |
This comment was marked as resolved.
This comment was marked as resolved.
|
For the record, I only recently took over maintenance of this package, and I apologize that the previous maintainer let it sit ignored for so long. |
ljharb
force-pushed
the
tape-options-support
branch
from
8703170 to
fa3c290
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for proposal #19. It contains everything described in that request, plus one thing.
This version of
faucetalso supports the word "assertions" appearing in place of "tests" in the output summary. The word "tests" is still allowed. See thistapeissue for an explanation. I currently havetapeopatchingtapeto say "assertions" instead (but patching is not stable long-term).