Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add discovering mvp #430

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

KaymeKaydex
Copy link

What has been done? Why? What problem is being solved?

I didn't forget about (remove if it is not applicable):

Related issues:

@KaymeKaydex KaymeKaydex marked this pull request as draft February 9, 2025 22:47
@KaymeKaydex
Copy link
Author

@oleg-jukovec can u check this one please? just like model and idea of discovery

@oleg-jukovec
Copy link
Collaborator

  1. It won't work like this because a replication pear address a some internal address which clients should not work with. In Tarantool 3 the situation is better and you can get this value from the config:

https://www.tarantool.io/en/doc/latest/reference/configuration/configuration_reference/#configuration-reference-iproto-advertise-client

  1. But we already have a private library for Tarantool 3 for such purposes: https://github.com/tarantool/go-discovery
  2. This pool does not work with a replicaset. It is a simple pool of connections to which you can add and remove connections. It is a flexible scheme and I would not like to change it. Autodiscovery is better implemented in a separate library based on this pool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants