Skip to content

Commit

Permalink
bug micronaut-projects#2228: consistent logging, format requested by CR
Browse files Browse the repository at this point in the history
  • Loading branch information
@podlesh
podlesh committed Oct 16, 2019
1 parent ef42b53 commit a53ba55
Showing 1 changed file with 121 additions and 125 deletions.
246 changes: 121 additions & 125 deletions http-client/src/main/java/io/micronaut/http/client/DefaultHttpClient.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1806,153 +1806,149 @@ protected void channelRead0(ChannelHandlerContext channelHandlerContext, FullHtt
} catch (IllegalArgumentException e) {
if (complete.compareAndSet(false, true)) {
emitter.onError(e);
} else {
getLog().warn("unsupported http status after completion", e);
} else if (LOG.isWarnEnabled()) {
LOG.warn("Unsupported http status after handler completed: " + e.getMessage(), e);
}
return;
}

handleResponse(fullResponse, status, statusCode, httpStatus);
} finally {
if (fullResponse.refCnt() > 0) {
try {
ReferenceCountUtil.release(fullResponse);
} catch (Throwable e) {
if (LOG.isDebugEnabled()) {
LOG.debug("Failed to release response: {}", fullResponse);
}
try {
HttpHeaders headers = fullResponse.headers();
if (log.isTraceEnabled()) {
log.trace("HTTP Client Response Received for Request: {} {}", request.getMethod(), request.getUri());
log.trace("Status Code: {}", status);
traceHeaders(headers);
traceBody("Response", fullResponse.content());
}
}
if (!HttpUtil.isKeepAlive(fullResponse)) {
keepAlive = false;
}
pipeline.remove(this);

}
}

private void handleResponse(FullHttpResponse fullResponse, HttpResponseStatus status, int statusCode, HttpStatus httpStatus) {
try {
HttpHeaders headers = fullResponse.headers();
if (log.isTraceEnabled()) {
log.trace("HTTP Client Response Received for Request: {} {}", request.getMethod(), request.getUri());
log.trace("Status Code: {}", status);
traceHeaders(headers);
traceBody("Response", fullResponse.content());
}

// it is a redirect
if (statusCode > 300 && statusCode < 400 && configuration.isFollowRedirects() && headers.contains(HttpHeaderNames.LOCATION)) {
String location = headers.get(HttpHeaderNames.LOCATION);
Flowable<io.micronaut.http.HttpResponse<O>> redirectedRequest = exchange(io.micronaut.http.HttpRequest.GET(location), bodyType);
redirectedRequest.first(io.micronaut.http.HttpResponse.notFound())
.subscribe((oHttpResponse, throwable) -> {
if (throwable != null) {
emitter.onError(throwable);
// it is a redirect
if (statusCode > 300 && statusCode < 400 && configuration.isFollowRedirects() && headers.contains(HttpHeaderNames.LOCATION)) {
String location = headers.get(HttpHeaderNames.LOCATION);
Flowable<io.micronaut.http.HttpResponse<O>> redirectedRequest = exchange(io.micronaut.http.HttpRequest.GET(location), bodyType);
redirectedRequest.first(io.micronaut.http.HttpResponse.notFound())
.subscribe((oHttpResponse, throwable) -> {
if (throwable != null) {
emitter.onError(throwable);

} else {
emitter.onNext(oHttpResponse);
emitter.onComplete();
}
});
return;
}
if (statusCode == HttpStatus.NO_CONTENT.getCode()) {
// normalize the NO_CONTENT header, since http content aggregator adds it even if not present in the response
headers.remove(HttpHeaderNames.CONTENT_LENGTH);
}
boolean errorStatus = statusCode >= 400;
FullNettyClientHttpResponse<O> response
= new FullNettyClientHttpResponse<>(fullResponse, httpStatus, mediaTypeCodecRegistry, byteBufferFactory, bodyType, errorStatus);

if (complete.compareAndSet(false, true)) {
if (errorStatus) {
try {
HttpClientResponseException clientError;
if (errorType != HttpClient.DEFAULT_ERROR_TYPE) {
clientError = new HttpClientResponseException(
status.reasonPhrase(),
null,
response,
new HttpClientErrorDecoder() {
@Override
public Argument<?> getErrorType(MediaType mediaType) {
return errorType;
}
}
);
} else {
emitter.onNext(oHttpResponse);
emitter.onComplete();
clientError = new HttpClientResponseException(
status.reasonPhrase(),
response
);
}
});
return;
}
if (statusCode == HttpStatus.NO_CONTENT.getCode()) {
// normalize the NO_CONTENT header, since http content aggregator adds it even if not present in the response
headers.remove(HttpHeaderNames.CONTENT_LENGTH);
}
boolean errorStatus = statusCode >= 400;
FullNettyClientHttpResponse<O> response
= new FullNettyClientHttpResponse<>(fullResponse, httpStatus, mediaTypeCodecRegistry, byteBufferFactory, bodyType, errorStatus);

if (complete.compareAndSet(false, true)) {
if (errorStatus) {
try {
HttpClientResponseException clientError;
if (errorType != HttpClient.DEFAULT_ERROR_TYPE) {
clientError = new HttpClientResponseException(
status.reasonPhrase(),
null,
response,
new HttpClientErrorDecoder() {
@Override
public Argument<?> getErrorType(MediaType mediaType) {
return errorType;
}
}
);
} else {
clientError = new HttpClientResponseException(
status.reasonPhrase(),
response
);
}
try {
emitter.onError(clientError);
} finally {
response.onComplete();
}
} catch (Throwable t) {
if (t instanceof HttpClientResponseException) {
try {
emitter.onError(t);
emitter.onError(clientError);
} finally {
response.onComplete();
}
} else {
response.onComplete();
FullNettyClientHttpResponse<Object> errorResponse = new FullNettyClientHttpResponse<>(
fullResponse,
httpStatus,
mediaTypeCodecRegistry,
byteBufferFactory,
null,
true
);
errorResponse.onComplete();
HttpClientResponseException clientResponseError = new HttpClientResponseException(
"Error decoding HTTP error response body: " + t.getMessage(),
t,
errorResponse,
null
);
} catch (Throwable t) {
if (t instanceof HttpClientResponseException) {
try {
emitter.onError(t);
} finally {
response.onComplete();
}
} else {
response.onComplete();
FullNettyClientHttpResponse<Object> errorResponse = new FullNettyClientHttpResponse<>(
fullResponse,
httpStatus,
mediaTypeCodecRegistry,
byteBufferFactory,
null,
true
);
errorResponse.onComplete();
HttpClientResponseException clientResponseError = new HttpClientResponseException(
"Error decoding HTTP error response body: " + t.getMessage(),
t,
errorResponse,
null
);
emitter.onError(clientResponseError);
}
}
} else {
emitter.onNext(response);
response.onComplete();
emitter.onComplete();
}
}
} catch (Throwable t) {
if (complete.compareAndSet(false, true)) {
if (t instanceof HttpClientResponseException) {
emitter.onError(t);
} else {
FullNettyClientHttpResponse<Object> response = new FullNettyClientHttpResponse<>(fullResponse, httpStatus, mediaTypeCodecRegistry, byteBufferFactory, null, true);
HttpClientResponseException clientResponseError = new HttpClientResponseException(
"Error decoding HTTP response body: " + t.getMessage(),
t,
response,
new HttpClientErrorDecoder() {
@Override
public Argument<?> getErrorType(MediaType mediaType) {
return errorType;
}
}
);
try {
emitter.onError(clientResponseError);
} finally {
response.onComplete();
}
}
} else {
emitter.onNext(response);
response.onComplete();
emitter.onComplete();
if (LOG.isWarnEnabled()) {
LOG.warn("Exception fired after handler completed: " + t.getMessage(), t);
}
}
}
} catch (Throwable t) {
if (complete.compareAndSet(false, true)) {
if (t instanceof HttpClientResponseException) {
emitter.onError(t);
} else {
FullNettyClientHttpResponse<Object> response = new FullNettyClientHttpResponse<>(fullResponse, httpStatus, mediaTypeCodecRegistry, byteBufferFactory, null, true);
HttpClientResponseException clientResponseError = new HttpClientResponseException(
"Error decoding HTTP response body: " + t.getMessage(),
t,
response,
new HttpClientErrorDecoder() {
@Override
public Argument<?> getErrorType(MediaType mediaType) {
return errorType;
}
}
);
try {
emitter.onError(clientResponseError);
} finally {
response.onComplete();
} finally {
if (fullResponse.refCnt() > 0) {
try {
ReferenceCountUtil.release(fullResponse);
} catch (Throwable e) {
if (LOG.isDebugEnabled()) {
LOG.debug("Failed to release response: {}", fullResponse);
}
}
} else {
if (LOG.isWarnEnabled()) {
LOG.warn("Exception fired after handler completed: " + t.getMessage(), t);
}
}
if (!HttpUtil.isKeepAlive(fullResponse)) {
keepAlive = false;
}
pipeline.remove(this);

}
}

Expand Down

0 comments on commit a53ba55

Please sign in to comment.