optimize table name

tarranjones · Mar 21, 2018 · b195d9e · b195d9e
1 parent 0af1c05
commit b195d9e
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/framework/db/ActiveRecord.php b/framework/db/ActiveRecord.php
@@ -209,8 +209,9 @@ protected static function filterCondition(array $condition)
         $result = [];
         // valid column names are table column names or column names prefixed with table name
         $columnNames = static::getTableSchema()->getColumnNames();
-        $columnNames = array_merge($columnNames, array_map(function($columnName) {
-            return static::tableName() . ".$columnName";
+        $tableName = static::tableName();
+        $columnNames = array_merge($columnNames, array_map(function($columnName) use ($tableName) {
+            return "$tableName.$columnName";
         }, $columnNames));
         foreach ($condition as $key => $value) {
             if (is_string($key) && !in_array($key, $columnNames, true)) {