Deprecate support for Velocity

Support for Velocity has been deprecated in Spring Framework 4.3 with
the plan being to remove it in 5.0. This commit deprecates Spring
Boot's support in 1.4, with the plan being to remove it in 2.0.

Closes spring-projectsgh-5276

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/velocity/VelocityAutoConfiguration.java

@@ -55,11 +55,14 @@
  * @author Andy Wilkinson
  * @author Brian Clozel
  * @since 1.1.0
+ * @deprecated In 1.4.0 following the deprecation of Velocity support in Spring Framework
+ * 4.3
  */
 @Configuration
 @ConditionalOnClass({ VelocityEngine.class, VelocityEngineFactory.class })
 @AutoConfigureAfter(WebMvcAutoConfiguration.class)
 @EnableConfigurationProperties(VelocityProperties.class)
+@Deprecated
 public class VelocityAutoConfiguration {
 
 	private static final Log logger = LogFactory.getLog(VelocityAutoConfiguration.class);
@@ -88,6 +91,7 @@ public void checkTemplateLocationExists() {
 		}
 	}
 
+	@Deprecated
 	protected static class VelocityConfiguration {
 
 		@Autowired
@@ -107,6 +111,7 @@ protected void applyProperties(VelocityEngineFactory factory) {
 
 	@Configuration
 	@ConditionalOnNotWebApplication
+	@Deprecated
 	public static class VelocityNonWebConfiguration extends VelocityConfiguration {
 
 		@Bean
@@ -122,6 +127,7 @@ public VelocityEngineFactoryBean velocityConfiguration() {
 	@Configuration
 	@ConditionalOnClass(Servlet.class)
 	@ConditionalOnWebApplication
+	@Deprecated
 	public static class VelocityWebConfiguration extends VelocityConfiguration {
 
 		@Bean

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/velocity/VelocityProperties.java

@@ -28,7 +28,10 @@
  *
  * @author Andy Wilkinson
  * @since 1.1.0
+ * @deprecated In 1.4.0 following the deprecation of Velocity support in Spring Framework
+ * 4.3
  */
+@Deprecated
 @ConfigurationProperties(prefix = "spring.velocity")
 public class VelocityProperties extends AbstractTemplateViewResolverProperties {
 

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/velocity/VelocityTemplateAvailabilityProvider.java

@@ -29,7 +29,10 @@
  *
  * @author Andy Wilkinson
  * @since 1.1.0
+ * @deprecated In 1.4.0 following the deprecation of Velocity support in Spring Framework
+ * 4.3
  */
+@Deprecated
 public class VelocityTemplateAvailabilityProvider
 		implements TemplateAvailabilityProvider {
 

spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/EnableAutoConfigurationImportSelectorTests.java

@@ -45,7 +45,9 @@
  *
  * @author Andy Wilkinson
  * @author Stephane Nicoll
+ *
  */
+@SuppressWarnings("deprecation")
 @RunWith(MockitoJUnitRunner.class)
 public class EnableAutoConfigurationImportSelectorTests {
 

spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/velocity/VelocityAutoConfigurationTests.java

@@ -54,6 +54,7 @@
  * @author Andy Wilkinson
  * @author Stephane Nicoll
  */
+@SuppressWarnings("deprecation")
 public class VelocityAutoConfigurationTests {
 
 	@Rule

spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/velocity/VelocityTemplateAvailabilityProviderTests.java

@@ -30,6 +30,7 @@
  *
  * @author Andy Wilkinson
  */
+@SuppressWarnings("deprecation")
 public class VelocityTemplateAvailabilityProviderTests {
 
 	private final TemplateAvailabilityProvider provider = new VelocityTemplateAvailabilityProvider();

spring-boot-docs/src/main/asciidoc/spring-boot-features.adoc

@@ -1577,7 +1577,7 @@ Spring Boot includes auto-configuration support for the following templating eng
  * http://freemarker.org/docs/[FreeMarker]
  * http://docs.groovy-lang.org/docs/next/html/documentation/template-engines.html#_the_markuptemplateengine[Groovy]
  * http://www.thymeleaf.org[Thymeleaf]
- * http://velocity.apache.org[Velocity]
+ * http://velocity.apache.org[Velocity] (deprecated in 1.4)
  * http://mustache.github.io/[Mustache]
 
 TIP: JSPs should be avoided if possible, there are several

spring-boot-docs/src/main/asciidoc/using-spring-boot.adoc

@@ -482,7 +482,7 @@ and Hibernate.
 |Support for the Thymeleaf templating engine, including integration with Spring.
 
 |`spring-boot-starter-velocity`
-|Support for the Velocity templating engine.
+|Support for the Velocity templating engine. Deprecated in 1.4.
 
 |`spring-boot-starter-web`
 |Support for full-stack web development, including Tomcat and `spring-webmvc`.

spring-boot-samples/spring-boot-sample-velocity/src/main/java/sample/velocity/SampleVelocityApplication.java

@@ -30,6 +30,7 @@
 import org.springframework.ui.velocity.VelocityEngineUtils;
 
 @SpringBootApplication
+@Deprecated
 public class SampleVelocityApplication implements CommandLineRunner {
 
 	@Value("${application.message}")

spring-boot-samples/spring-boot-sample-velocity/src/test/java/sample/velocity/SampleVelocityApplicationTests.java

@@ -33,6 +33,7 @@
  */
 @RunWith(SpringJUnit4ClassRunner.class)
 @SpringApplicationConfiguration(SampleVelocityApplication.class)
+@SuppressWarnings("deprecation")
 public class SampleVelocityApplicationTests {
 
 	@ClassRule

spring-boot/src/main/java/org/springframework/boot/web/servlet/view/velocity/EmbeddedVelocityViewResolver.java

@@ -26,7 +26,10 @@
  *
  * @author Phillip Webb
  * @since 1.2.5
+ * @deprecated In 1.4.0 following the deprecation of Velocity support in Spring Framework
+ * 4.3
  */
+@Deprecated
 public class EmbeddedVelocityViewResolver extends VelocityViewResolver {
 
 	private String toolboxConfigLocation;

spring-boot/src/test/java/org/springframework/boot/web/servlet/view/velocity/EmbeddedVelocityToolboxViewTests.java

@@ -40,6 +40,7 @@
  *
  * @author Phillip Webb
  */
+@SuppressWarnings("deprecation")
 public class EmbeddedVelocityToolboxViewTests {
 
 	private static final String PATH = EmbeddedVelocityToolboxViewTests.class.getPackage()

spring-boot/src/test/java/org/springframework/boot/web/servlet/view/velocity/EmbeddedVelocityViewResolverTests.java

@@ -34,6 +34,7 @@
  *
  * @author Phillip Webb
  */
+@SuppressWarnings("deprecation")
 public class EmbeddedVelocityViewResolverTests {
 
 	@Test