Make Skia cache size channel respond with a value (flutter#11550)

tauu · Aug 28, 2019 · 4ceaafc · 4ceaafc
1 parent 85810f8
commit 4ceaafc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/shell/common/fixtures/shell_test.dart b/shell/common/fixtures/shell_test.dart
@@ -63,6 +63,9 @@ void testCanLaunchSecondaryIsolate() {
 @pragma('vm:entry-point')
 void testSkiaResourceCacheSendsResponse() {
   final PlatformMessageResponseCallback callback = (ByteData data) {
+    if (data == null) {
+      throw 'Response must not be null.';
+    }
     notifyNative();
   };
   const String json = '''{

diff --git a/shell/common/shell.cc b/shell/common/shell.cc
@@ -959,7 +959,9 @@ void Shell::HandleEngineSkiaMessage(fml::RefPtr<PlatformMessage> message) {
                                                true);
         }
         if (response) {
-          response->CompleteEmpty();
+          std::vector<uint8_t> data = {1};
+          response->Complete(
+              std::make_unique<fml::DataMapping>(std::move(data)));
         }
       });
 }