Refactor BaGet's architecture (loic-sharma#508)

⚠️ This pull request has several breaking changes. I apologize for any pain this may cause.

Refactors several pieces of BaGet's architecture:

* Renamed the `BaGet.Core.Server` project to `BaGet.Hosting`, it will contain ASP.NET Core integration bits
* Unified the hosts used to run commands and the service
* Updated the integration tests to use the `WebApplicationFactory` pattern
* Reduced the number of namespaces

BaGet.sln

@@ -30,7 +30,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
 		nuget.config = nuget.config
 	EndProjectSection
 EndProject
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "BaGet.Core.Server", "src\BaGet.Core.Server\BaGet.Core.Server.csproj", "{D68B56AC-98DD-4DA7-B4F8-1243538A8A5C}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "BaGet.Hosting", "src\BaGet.Hosting\BaGet.Hosting.csproj", "{D68B56AC-98DD-4DA7-B4F8-1243538A8A5C}"
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "BaGet.Database.Sqlite", "src\BaGet.Database.Sqlite\BaGet.Database.Sqlite.csproj", "{EC5E6B2C-2494-40E8-8682-080BA580DDA7}"
 EndProject
@@ -46,7 +46,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "samples", "samples", "{DDEC
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "BaGet.Protocol.Samples.Tests", "samples\BaGet.Protocol.Samples.Tests.csproj", "{16B0D424-BB2F-4C0C-90B0-4F7955326ADF}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "BaGet.Aliyun", "src\BaGet.Aliyun\BaGet.Aliyun.csproj", "{9F7C4F38-D598-42D9-A9F8-962490483B18}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "BaGet.Aliyun", "src\BaGet.Aliyun\BaGet.Aliyun.csproj", "{9F7C4F38-D598-42D9-A9F8-962490483B18}"
 EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution

src/BaGet.Aliyun/AliyunStorageService.cs

@@ -3,7 +3,6 @@
 using System.Threading;
 using System.Threading.Tasks;
 using Aliyun.OSS;
-using BaGet.Aliyun.Configuration;
 using BaGet.Core;
 using Microsoft.Extensions.Options;
 

src/BaGet.Aliyun/Configuration/AliyunStorageOptions.cs

@@ -1,7 +1,6 @@
 using System.ComponentModel.DataAnnotations;
-using BaGet.Core;
 
-namespace BaGet.Aliyun.Configuration
+namespace BaGet.Aliyun
 {
     public class AliyunStorageOptions
     {

src/BaGet.Aliyun/Extensions/ServiceCollectionExtensions.cs

@@ -1,10 +1,8 @@
-using System;
 using Aliyun.OSS;
-using BaGet.Aliyun.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Options;
 
-namespace BaGet.Aliyun.Extensions
+namespace BaGet.Aliyun
 {
     public static class ServiceCollectionExtensions
     {

src/BaGet.Aws/Configuration/S3StorageOptions.cs

@@ -1,7 +1,7 @@
 using System.ComponentModel.DataAnnotations;
 using BaGet.Core;
 
-namespace BaGet.Aws.Configuration
+namespace BaGet.Aws
 {
     public class S3StorageOptions
     {

src/BaGet.Aws/Extensions/ServiceCollectionExtensions.cs

@@ -2,12 +2,10 @@
 using Amazon;
 using Amazon.Runtime;
 using Amazon.S3;
-using BaGet.Aws.Configuration;
-using BaGet.Aws.Helpers;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Options;
 
-namespace BaGet.Aws.Extensions
+namespace BaGet.Aws
 {
     public static class ServiceCollectionExtensions
     {

src/BaGet.Aws/Helpers/AwsIamHelper.cs

@@ -2,7 +2,7 @@
 using System.Threading.Tasks;
 using Amazon.Runtime;
 
-namespace BaGet.Aws.Helpers
+namespace BaGet.Aws
 {
     public static class AwsIamHelper
     {

src/BaGet.Aws/S3StorageService.cs

@@ -4,7 +4,6 @@
 using System.Threading.Tasks;
 using Amazon.S3;
 using Amazon.S3.Model;
-using BaGet.Aws.Configuration;
 using BaGet.Core;
 using Microsoft.Extensions.Options;
 

src/BaGet.Azure/Extensions/IServiceCollectionExtensions.cs → src/BaGet.Azure/Extensions/DependencyInjectionExtensions.cs

@@ -12,7 +12,7 @@ namespace BaGet.Azure
 
     using TableStorageAccount = Microsoft.Azure.Cosmos.Table.CloudStorageAccount;
 
-    public static class IServiceCollectionExtensions
+    public static class DependencyInjectionExtensions
     {
         public static IServiceCollection AddTableStorageService(this IServiceCollection services)
         {

src/BaGet.Azure/Extensions/StorageExceptionExtensions.cs

@@ -1,6 +1,6 @@
 using System.Net;
 
-namespace BaGet.Azure.Extensions
+namespace BaGet.Azure
 {
     using StorageException = Microsoft.WindowsAzure.Storage.StorageException;
     using TableStorageException = Microsoft.Azure.Cosmos.Table.StorageException;

src/BaGet.Azure/Storage/BlobStorageService.cs

@@ -2,7 +2,6 @@
 using System.IO;
 using System.Threading;
 using System.Threading.Tasks;
-using BaGet.Azure.Extensions;
 using BaGet.Core;
 using Microsoft.WindowsAzure.Storage;
 using Microsoft.WindowsAzure.Storage.Blob;

src/BaGet.Azure/Table/TablePackageService.cs

@@ -3,7 +3,6 @@
 using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
-using BaGet.Azure.Extensions;
 using BaGet.Core;
 using Microsoft.Azure.Cosmos.Table;
 using Microsoft.Extensions.Logging;

src/BaGet.Core/Content/DefaultPackageContentService.cs

@@ -6,7 +6,7 @@
 using BaGet.Protocol.Models;
 using NuGet.Versioning;
 
-namespace BaGet.Core.Content
+namespace BaGet.Core
 {
     /// <summary>
     /// Implements the NuGet Package Content resource. Supports read-through caching.

src/BaGet.Core/Content/IPackageContentService.cs

@@ -4,7 +4,7 @@
 using BaGet.Protocol.Models;
 using NuGet.Versioning;
 
-namespace BaGet.Core.Content
+namespace BaGet.Core
 {
     /// <summary>
     /// The Package Content resource, used to download NuGet packages and to fetch other metadata.

src/BaGet.Core/Extensions/ServiceCollectionExtensions.cs → src/BaGet.Core/Extensions/DependencyInjectionExtensions.cs

@@ -4,7 +4,7 @@
 
 namespace BaGet.Core
 {
-    public static class ServiceCollectionExtensions
+    public static class DependencyInjectionExtensions
     {
         public static IServiceCollection ConfigureAndValidate<TOptions>(
             this IServiceCollection services,

src/BaGet.Gcp/Configuration/GoogleCloudStorageOptions.cs

@@ -1,7 +1,7 @@
 using System.ComponentModel.DataAnnotations;
 using BaGet.Core;
 
-namespace BaGet.Gcp.Configuration
+namespace BaGet.Gcp
 {
     public class GoogleCloudStorageOptions : StorageOptions
     {

src/BaGet.Gcp/Extensions/ServiceCollectionExtensions.cs

@@ -1,7 +1,6 @@
-using BaGet.Gcp.Services;
 using Microsoft.Extensions.DependencyInjection;
 
-namespace BaGet.Gcp.Extensions
+namespace BaGet.Gcp
 {
     public static class ServiceCollectionExtensions
     {

src/BaGet.Gcp/Services/GoogleCloudStorageService.cs

@@ -6,12 +6,11 @@
 using System.Threading;
 using System.Threading.Tasks;
 using BaGet.Core;
-using BaGet.Gcp.Configuration;
 using Google;
 using Google.Cloud.Storage.V1;
 using Microsoft.Extensions.Options;
 
-namespace BaGet.Gcp.Services
+namespace BaGet.Gcp
 {
     public class GoogleCloudStorageService : IStorageService
     {

src/BaGet.Core.Server/BaGetUrlGenerator.cs → src/BaGet.Hosting/BaGetUrlGenerator.cs

@@ -4,7 +4,7 @@
 using Microsoft.AspNetCore.Routing;
 using NuGet.Versioning;
 
-namespace BaGet
+namespace BaGet.Hosting
 {
     // TODO: This should validate the "Host" header against known valid values
     public class BaGetUrlGenerator : IUrlGenerator

src/BaGet.Core.Server/Configuration/ConfigureCorsOptions.cs → src/BaGet.Hosting/Configuration/ConfigureCorsOptions.cs

@@ -1,14 +1,15 @@
 using Microsoft.AspNetCore.Cors.Infrastructure;
 using Microsoft.Extensions.Options;
 
-namespace BaGet.Configuration
+namespace BaGet.Hosting
 {
     public class ConfigureCorsOptions : IConfigureOptions<CorsOptions>
     {
         public const string CorsPolicy = "AllowAll";
 
         public void Configure(CorsOptions options)
         {
+            // TODO: Consider disabling this on production builds.
             options.AddPolicy(
                 CorsPolicy,
                 builder => builder.AllowAnyOrigin()

src/BaGet.Core.Server/Configuration/ConfigureForwardedHeadersOptions.cs → src/BaGet.Hosting/Configuration/ConfigureForwardedHeadersOptions.cs

@@ -2,7 +2,7 @@
 using Microsoft.AspNetCore.HttpOverrides;
 using Microsoft.Extensions.Options;
 
-namespace BaGet.Configuration
+namespace BaGet.Hosting
 {
     public class ConfigureForwardedHeadersOptions : IConfigureOptions<ForwardedHeadersOptions>
     {

src/BaGet.Core.Server/Controllers/PackageContentController.cs → src/BaGet.Hosting/Controllers/PackageContentController.cs

@@ -1,12 +1,12 @@
 using System;
 using System.Threading;
 using System.Threading.Tasks;
-using BaGet.Core.Content;
+using BaGet.Core;
 using BaGet.Protocol.Models;
 using Microsoft.AspNetCore.Mvc;
 using NuGet.Versioning;
 
-namespace BaGet.Controllers
+namespace BaGet.Hosting
 {
     /// <summary>
     /// The Package Content resource, used to download content from packages.

src/BaGet.Core.Server/Controllers/PackageMetadataController.cs → src/BaGet.Hosting/Controllers/PackageMetadataController.cs

@@ -6,7 +6,7 @@
 using Microsoft.AspNetCore.Mvc;
 using NuGet.Versioning;
 
-namespace BaGet.Controllers
+namespace BaGet.Hosting
 {
     /// <summary>
     /// The Package Metadata resource, used to fetch packages' information.

src/BaGet.Core.Server/Controllers/PackagePublishController.cs → src/BaGet.Hosting/Controllers/PackagePublishController.cs

@@ -2,13 +2,12 @@
 using System.Threading;
 using System.Threading.Tasks;
 using BaGet.Core;
-using BaGet.Extensions;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
 using NuGet.Versioning;
 
-namespace BaGet.Controllers
+namespace BaGet.Hosting
 {
     public class PackagePublishController : Controller
     {

src/BaGet.Core.Server/Controllers/SearchController.cs → src/BaGet.Hosting/Controllers/SearchController.cs

@@ -5,7 +5,7 @@
 using BaGet.Protocol.Models;
 using Microsoft.AspNetCore.Mvc;
 
-namespace BaGet.Controllers
+namespace BaGet.Hosting
 {
     public class SearchController : Controller
     {

src/BaGet.Core.Server/Controllers/ServiceIndexController.cs → src/BaGet.Hosting/Controllers/ServiceIndexController.cs

@@ -5,7 +5,7 @@
 using BaGet.Protocol.Models;
 using Microsoft.AspNetCore.Mvc;
 
-namespace BaGet.Controllers
+namespace BaGet.Hosting
 {
     /// <summary>
     /// The NuGet Service Index. This aids NuGet client to discover this server's services.

src/BaGet.Core.Server/Controllers/SymbolController.cs → src/BaGet.Hosting/Controllers/SymbolController.cs

@@ -2,12 +2,11 @@
 using System.Threading;
 using System.Threading.Tasks;
 using BaGet.Core;
-using BaGet.Extensions;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
 
-namespace BaGet.Controllers
+namespace BaGet.Hosting
 {
     public class SymbolController : Controller
     {

src/BaGet.Core.Server/Extensions/HttpRequestExtensions.cs → src/BaGet.Hosting/Extensions/HttpRequestExtensions.cs

@@ -4,7 +4,7 @@
 using BaGet.Core;
 using Microsoft.AspNetCore.Http;
 
-namespace BaGet.Extensions
+namespace BaGet.Hosting
 {
     public static class HttpRequestExtensions
     {

src/BaGet.Core.Server/Extensions/IApplicationBuilderExtensions.cs → src/BaGet.Hosting/Extensions/IApplicationBuilderExtensions.cs

@@ -1,7 +1,7 @@
 using System;
 using Microsoft.AspNetCore.Builder;
 
-namespace BaGet.Core.Server.Extensions
+namespace BaGet.Hosting
 {
     public static class IApplicationBuilderExtensions
     {

src/BaGet.Core.Server/Extensions/IEndpointRouteBuilderExtensions.cs → src/BaGet.Hosting/Extensions/IEndpointRouteBuilderExtensions.cs

@@ -2,7 +2,7 @@
 using Microsoft.AspNetCore.Routing;
 using Microsoft.AspNetCore.Routing.Constraints;
 
-namespace BaGet.Extensions
+namespace BaGet.Hosting
 {
     public static class IEndpointRouteBuilderExtensions
     {

src/BaGet.Core.Server/Extensions/IHostExtensions.cs → src/BaGet.Hosting/Extensions/IHostExtensions.cs

@@ -1,12 +1,11 @@
 using System.Threading;
 using System.Threading.Tasks;
 using BaGet.Core;
-using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Hosting;
 using Microsoft.Extensions.Options;
 
-namespace BaGet.Extensions
+namespace BaGet.Hosting
 {
     public static class IHostExtensions
     {

src/BaGet.Core.Server/Extensions/IServiceCollectionExtensions.cs → src/BaGet.Hosting/Extensions/IServiceCollectionExtensions.cs

@@ -1,5 +1,3 @@
-using BaGet.Configuration;
-using BaGet.Controllers;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Cors.Infrastructure;
 using Microsoft.AspNetCore.Http.Features;
@@ -8,7 +6,7 @@
 using Microsoft.Extensions.Options;
 using Newtonsoft.Json;
 
-namespace BaGet.Core.Server.Extensions
+namespace BaGet.Hosting
 {
     public static class IServiceCollectionExtensions
     {

src/BaGet.Core.Server/OperationCancelledMiddleware.cs → src/BaGet.Hosting/OperationCancelledMiddleware.cs

@@ -4,7 +4,7 @@
 using Microsoft.AspNetCore.Http;
 using Microsoft.Extensions.Logging;
 
-namespace BaGet
+namespace BaGet.Hosting
 {
     /// <summary>
     /// Captures <see cref="OperationCanceledException" /> and converts to HTTP 409 response.

src/BaGet.Core.Server/Routes.cs → src/BaGet.Hosting/Routes.cs

@@ -1,4 +1,4 @@
-namespace BaGet
+namespace BaGet.Hosting
 {
     public class Routes
     {

src/BaGet/BaGet.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk.Web">
+<Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
     <TargetFramework>netcoreapp3.1</TargetFramework>
@@ -18,12 +18,12 @@
     <ProjectReference Include="..\BaGet.Aws\BaGet.Aws.csproj" />
     <ProjectReference Include="..\BaGet.Azure\BaGet.Azure.csproj" />
     <ProjectReference Include="..\BaGet.Core\BaGet.Core.csproj" />
-    <ProjectReference Include="..\BaGet.Core.Server\BaGet.Core.Server.csproj" />
     <ProjectReference Include="..\BaGet.Database.MySql\BaGet.Database.MySql.csproj" />
     <ProjectReference Include="..\BaGet.Database.PostgreSql\BaGet.Database.PostgreSql.csproj" />
     <ProjectReference Include="..\BaGet.Database.Sqlite\BaGet.Database.Sqlite.csproj" />
     <ProjectReference Include="..\BaGet.Database.SqlServer\BaGet.Database.SqlServer.csproj" />
     <ProjectReference Include="..\BaGet.Gcp\BaGet.Gcp.csproj" />
+    <ProjectReference Include="..\BaGet.Hosting\BaGet.Hosting.csproj" />
     <ProjectReference Include="..\BaGet.Protocol\BaGet.Protocol.csproj" />
   </ItemGroup>