do not block to send usage stats (influxdata#591)

tct492 · Jun 1, 2016 · 7334efe · 7334efe
1 parent 880d1cf
commit 7334efe
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -105,6 +105,7 @@ kapacitor replay-live query -task cpu_alert -query 'SELECT usage_idle FROM teleg
 - [#555](https://github.com/influxdata/kapacitor/issues/555): Fixes bug where "time" functions didn't work in lambda expressions.
 - [#570](https://github.com/influxdata/kapacitor/issues/570): Removes panic in SMTP service on failed close connection.
 - [#587](https://github.com/influxdata/kapacitor/issues/587): Allow number literals without leading zeros.
+- [#584](https://github.com/influxdata/kapacitor/issues/584): Do not block during startup to send usage stats.
 
 ## v0.13.1 [2016-05-13]
 

diff --git a/services/reporting/service.go b/services/reporting/service.go
@@ -60,15 +60,22 @@ func (s *Service) Open() error {
 	s.tags["os"] = runtime.GOOS
 
 	// Send report on startup
-	err := s.sendUsageReport()
-	if err != nil {
-		s.logger.Println("E! error while sending usage report on startup:", err)
-	}
+	s.wg.Add(1)
+	go func() {
+		defer s.wg.Done()
+		err := s.sendUsageReport()
+		if err != nil {
+			s.logger.Println("E! error while sending usage report on startup:", err)
+		}
+	}()
 
 	// Send periodic anonymous usage stats
 	s.usageTicker = time.NewTicker(reportingInterval)
 	s.wg.Add(1)
-	go s.usage()
+	go func() {
+		defer s.wg.Done()
+		s.usage()
+	}()
 	return nil
 }
 
@@ -87,7 +94,6 @@ func (s *Service) Close() error {
 }
 
 func (s *Service) usage() {
-	defer s.wg.Done()
 	for {
 		select {
 		case <-s.closing: