Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go mod に対応しました #5

Merged
merged 6 commits into from
Jul 19, 2020
Merged

go mod に対応しました #5

merged 6 commits into from
Jul 19, 2020

Conversation

135yshr
Copy link
Contributor

@135yshr 135yshr commented Jul 13, 2020

No description provided.

@grimrose
Copy link
Member

travis.ymlも1.13に対応できそうですかね?

@135yshr
Copy link
Contributor Author

135yshr commented Jul 19, 2020

できます！

sue445
sue445 reviewed Jul 19, 2020
View reviewed changes
go.mod Outdated
@@ -0,0 +1,5 @@
module github.com/135yshr/go_gotest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tddbc orgなのでこっちが正しそうです

Suggested change
module github.com/135yshr/go_gotest
module github.com/tddbc/go_gotest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ。。確かに。ありがとうございます

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正しました

@sue445
Copy link
Contributor

sue445 commented Jul 19, 2020

LTGM 🙆‍♀️

@sue445 sue445 merged commit a0dc565 into tddbc:master Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sue445 sue445 sue445 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@135yshr @grimrose @sue445